Opened 5 months ago

Closed 5 months ago

Last modified 4 months ago

#5243 closed defect (fixed)

[ABP for Samsung Internet] - Clipped text across languages

Reported by: Shikitita Assignee: jwangenheim
Priority: P3 Milestone: Adblock-Plus-for-Samsung-Browser-1.1.1
Module: Adblock-Plus-for-Samsung-Browser Keywords:
Cc: jwangenheim, diegocarloslima, mario, lisabielik, vickyyu Blocked By:
Blocking: Platform: Samsung Browser
Ready: yes Confidential: no
Tester: Unknown Verified working: yes
Review URL(s):

https://codereview.adblockplus.org/29441558/

Description (last modified by Shikitita)

Environment

Platform: Samsung S6
OS: Android 6.0.1

How to reproduce

  1. Install Adblock Plus for Samsung Internet and enable the content blocking functionality in Samsung Internet
  2. Change the device's language into Turkish
  3. Access ABP for Samsung Internet and tap on "Daha fazla engelleme seçeneği"

Observed behaviour

Three of the four different options have their text clipped at the end, as can be seen in the attached screenshot. The text "devre dışı bırak", which can't be read completely, means "disable" in Turkish and therefore should be properly displayed.

Note that this happens in other screens and in most languages except for Korean.

Expected behaviour

The text should be wrapped in order to display it fully to the user and help avoid misunderstandings.

Even though aesthetically it won't be too nice having the text in two lines, it is better than reducing the font's size (which should be done to all languages for that matter).

Attachments (6)

Clipped text.png (108.1 KB) - added by Shikitita 5 months ago.
Screenshot_2017-05-16-15-06-00.png (126.9 KB) - added by jwangenheim 5 months ago.
Screenshot_2017-05-16-15-06-24.png (164.2 KB) - added by jwangenheim 5 months ago.
SBrowser 4.0 or superior.png (220.7 KB) - added by Shikitita 5 months ago.
"Enable Adblock Plus in Samsung Internet 4.0 or above" clipped in French
Screenshot_2017-05-16-15-32-40.png (64.8 KB) - added by jwangenheim 5 months ago.
Screenshot_2017-05-16-15-35-43.png (231.3 KB) - added by jwangenheim 5 months ago.

Download all attachments as: .zip

Change History (23)

Changed 5 months ago by Shikitita

comment:1 Changed 5 months ago by Shikitita

  • Description modified (diff)

Changed 5 months ago by jwangenheim

Changed 5 months ago by jwangenheim

comment:2 Changed 5 months ago by jwangenheim

Text for items in "More blocking options" and "Acceptable Ads" (on startpage) can now be displayed in multiple lines. Please let me know what else should be displayed in two lines.

Last edited 5 months ago by jwangenheim (previous) (diff)

comment:3 follow-up: Changed 5 months ago by Shikitita

Strings that would need to be displayed also in two lines:

  • Add a website to the whitelist (affects different languages)
  • Configure your filter lists (affects Greek)

Also "Enable Adblock Plus in Samsung Internet 4.0 or above" is displayed clipped for quite a few of the languages. However, it's already displayed in two lines and maybe having it in three wouldn't look so nice. :-/ You can see this in the screenshot below

Changed 5 months ago by Shikitita

"Enable Adblock Plus in Samsung Internet 4.0 or above" clipped in French

Changed 5 months ago by jwangenheim

Changed 5 months ago by jwangenheim

comment:4 in reply to: ↑ 3 ; follow-up: Changed 5 months ago by jwangenheim

Replying to Shikitita:

Strings that would need to be displayed also in two lines:

  • Add a website to the whitelist (affects different languages)
  • Configure your filter lists (affects Greek)

Also "Enable Adblock Plus in Samsung Internet 4.0 or above" is displayed clipped for quite a few of the languages. However, it's already displayed in two lines and maybe having it in three wouldn't look so nice. :-/ You can see this in the screenshot below

I've fixed the first two texts too. For the dialog title I would suggest to display it in three lines, as this would only affect french users. In my opinion this is better than having a smaller text size for all languages.

comment:5 in reply to: ↑ 4 ; follow-up: Changed 5 months ago by Shikitita

Replying to jwangenheim:

Replying to Shikitita:

Also "Enable Adblock Plus in Samsung Internet 4.0 or above" is displayed clipped for quite a few of the languages. However, it's already displayed in two lines and maybe having it in three wouldn't look so nice. :-/ You can see this in the screenshot below

I've fixed the first two texts too. For the dialog title I would suggest to display it in three lines, as this would only affect french users. In my opinion this is better than having a smaller text size for all languages.

Unfortunately, like I mentioned above, this one is displayed clipped for quite a few languages: French, Greek, Turkish, German, Polish, Russian.

comment:6 in reply to: ↑ 5 ; follow-up: Changed 5 months ago by jwangenheim

Replying to Shikitita:

Replying to jwangenheim:

Replying to Shikitita:

Also "Enable Adblock Plus in Samsung Internet 4.0 or above" is displayed clipped for quite a few of the languages. However, it's already displayed in two lines and maybe having it in three wouldn't look so nice. :-/ You can see this in the screenshot below

I've fixed the first two texts too. For the dialog title I would suggest to display it in three lines, as this would only affect french users. In my opinion this is better than having a smaller text size for all languages.

Unfortunately, like I mentioned above, this one is displayed clipped for quite a few languages: French, Greek, Turkish, German, Polish, Russian.

Sorry, missed that. Then it might make sense to just use "Enable Adblock Plus in Samsung Internet"?

comment:7 Changed 5 months ago by Shikitita

  • Cc lisabielik added

comment:8 Changed 5 months ago by jwangenheim

  • Cc lisabielik removed
  • Owner set to jwangenheim
  • Ready set

comment:9 Changed 5 months ago by jwangenheim

  • Cc lisabielik added

comment:10 in reply to: ↑ 6 ; follow-up: Changed 5 months ago by Shikitita

  • Cc vickyyu added

Replying to jwangenheim:

Replying to Shikitita:

Replying to jwangenheim:

Replying to Shikitita:

Also "Enable Adblock Plus in Samsung Internet 4.0 or above" is displayed clipped for quite a few of the languages. However, it's already displayed in two lines and maybe having it in three wouldn't look so nice. :-/ You can see this in the screenshot below

I've fixed the first two texts too. For the dialog title I would suggest to display it in three lines, as this would only affect french users. In my opinion this is better than having a smaller text size for all languages.

Unfortunately, like I mentioned above, this one is displayed clipped for quite a few languages: French, Greek, Turkish, German, Polish, Russian.

Sorry, missed that. Then it might make sense to just use "Enable Adblock Plus in Samsung Internet"?

Funny enough, that's how the string used to be before. However, not sure if we added the "4.0 or above" in order to make sure users knew that it'd only work in those versions of Samsung Internet. :-/

@lisa, vicky: Any thoughts on the above?

comment:11 in reply to: ↑ 10 Changed 5 months ago by jwangenheim

Replying to Shikitita:

Replying to jwangenheim:

Replying to Shikitita:

Replying to jwangenheim:

Replying to Shikitita:

Also "Enable Adblock Plus in Samsung Internet 4.0 or above" is displayed clipped for quite a few of the languages. However, it's already displayed in two lines and maybe having it in three wouldn't look so nice. :-/ You can see this in the screenshot below

I've fixed the first two texts too. For the dialog title I would suggest to display it in three lines, as this would only affect french users. In my opinion this is better than having a smaller text size for all languages.

Unfortunately, like I mentioned above, this one is displayed clipped for quite a few languages: French, Greek, Turkish, German, Polish, Russian.

Sorry, missed that. Then it might make sense to just use "Enable Adblock Plus in Samsung Internet"?

Funny enough, that's how the string used to be before. However, not sure if we added the "4.0 or above" in order to make sure users knew that it'd only work in those versions of Samsung Internet. :-/

@lisa, vicky: Any thoughts on the above?

But if I understand the workflow correctly, this dialog is only displayed to users with at least Samsung Browser 4.0

comment:12 Changed 5 months ago by jwangenheim

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:13 Changed 5 months ago by jwangenheim

  • Review URL(s) modified (diff)

comment:14 Changed 5 months ago by diegocarloslima

  • Priority changed from Unknown to P3

comment:15 Changed 5 months ago by abpbot

A commit referencing this issue has landed:
Issue 5243 - Clipped text across languages

comment:16 Changed 5 months ago by jwangenheim

  • Milestone set to Adblock-Plus-for-Samsung-Browser-next
  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:17 Changed 4 months ago by Shikitita

  • Verified working set
Note: See TracTickets for help on using tickets.