Opened 2 years ago

Closed 2 years ago

#5244 closed defect (fixed)

[ABP for Samsung Internet] - Misaligned text in Korean

Reported by: Shikitita Assignee: jwangenheim
Priority: Unknown Milestone: Adblock-Plus-for-Samsung-Browser-1.1.0
Module: Adblock-Plus-for-Samsung-Browser Keywords:
Cc: jwangenheim, diegocarloslima, mario Blocked By:
Blocking: Platform: Samsung Browser
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29439588/

Description

Environment

Platform: Samsung S6
OS: Android 6.0.1

How to reproduce

  1. Install Adblock Plus for Samsung Internet
  2. Without enabling the content blocking functionality in Samsung Internet, change the device's language into Korean
  3. Access ABP for Samsung Internet making sure that the steps on how to enable it on Samsung Internet are still displayed
  1. Change now the device's language into German and proceed again with step number 3

Observed behaviour

The text "Configure Samsung Internet" in Korean is misplaced to the left instead of centered like the rest of the languages.

This occurs with the steps for both Samsung Internet v. 4 and v. 5.

Expected behaviour

The text should be displayed in the centre in order to keep consistency with the rest of the languages as well as for aesthetic reasons.

Attachments (2)

Misaligned Korean Text.png (182.6 KB) - added by Shikitita 2 years ago.
Centered German Text.png (203.4 KB) - added by Shikitita 2 years ago.

Download all attachments as: .zip

Change History (6)

Changed 2 years ago by Shikitita

Changed 2 years ago by Shikitita

comment:1 Changed 2 years ago by jwangenheim

  • Owner set to jwangenheim

comment:2 Changed 2 years ago by jwangenheim

  • Ready set
  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:3 Changed 2 years ago by abpbot

A commit referencing this issue has landed:
Issue 5244 - Misaligned text in Korean

comment:4 Changed 2 years ago by jwangenheim

  • Milestone set to Adblock-Plus-for-Samsung-Browser-1.1.0
  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.