Opened 7 months ago

Closed 5 months ago

Last modified 3 months ago

#5254 closed change (fixed)

Improve URL verification when whitelisting domains

Reported by: mario Assignee: jwangenheim
Priority: P3 Milestone: Adblock-Plus-for-Samsung-Browser-1.1.2
Module: Adblock-Plus-for-Samsung-Browser Keywords:
Cc: Blocked By:
Blocking: Platform: Samsung Browser
Ready: yes Confidential: no
Tester: Unknown Verified working: yes
Review URL(s):

https://codereview.adblockplus.org/29480569/

Description

Background

This is a follow-up of #4769. As per #4769 we introduced the possibility to add websites to the whitelist. However for URL verification we internally rely on Patterns.WEB_URL.matcher which only checks for the URL's pattern. Thus invalid TLD's can be entered.

What to change

Change the internal URL validation to also test against validity of the TLD.

Change History (7)

comment:1 Changed 7 months ago by diegocarloslima

  • Priority changed from Unknown to P3
  • Ready set

comment:2 Changed 6 months ago by jwangenheim

  • Owner set to jwangenheim

comment:3 Changed 6 months ago by jwangenheim

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:4 Changed 5 months ago by abpbot

A commit referencing this issue has landed:
Issue 5254 - Improve URL verification when whitelisting domains

comment:5 Changed 5 months ago by jwangenheim

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:6 Changed 5 months ago by diegocarloslima

  • Milestone set to Adblock-Plus-for-Samsung-Browser-next

comment:7 Changed 3 months ago by rscott

  • Verified working set
Note: See TracTickets for help on using tickets.