Opened on 05/17/2017 at 06:48:15 AM

Closed on 07/26/2017 at 08:39:48 AM

Last modified on 09/28/2017 at 04:57:52 PM

#5254 closed change (fixed)

Improve URL verification when whitelisting domains

Reported by: mario Assignee: jwangenheim
Priority: P3 Milestone: Adblock-Plus-for-Samsung-Browser-1.1.2
Module: Adblock-Plus-for-Samsung-Browser Keywords:
Cc: Blocked By:
Blocking: Platform: Samsung Browser
Ready: yes Confidential: no
Tester: Unknown Verified working: yes
Review URL(s):



This is a follow-up of #4769. As per #4769 we introduced the possibility to add websites to the whitelist. However for URL verification we internally rely on Patterns.WEB_URL.matcher which only checks for the URL's pattern. Thus invalid TLD's can be entered.

What to change

Change the internal URL validation to also test against validity of the TLD.

Attachments (0)

Change History (7)

comment:1 Changed on 05/23/2017 at 03:24:33 PM by diegocarloslima

  • Priority changed from Unknown to P3
  • Ready set

comment:2 Changed on 06/14/2017 at 02:38:26 PM by jwangenheim

  • Owner set to jwangenheim

comment:3 Changed on 07/05/2017 at 09:16:20 AM by jwangenheim

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:4 Changed on 07/26/2017 at 08:29:18 AM by abpbot

A commit referencing this issue has landed:
Issue 5254 - Improve URL verification when whitelisting domains

comment:5 Changed on 07/26/2017 at 08:39:48 AM by jwangenheim

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:6 Changed on 07/27/2017 at 04:11:34 PM by diegocarloslima

  • Milestone set to Adblock-Plus-for-Samsung-Browser-next

comment:7 Changed on 09/28/2017 at 04:57:52 PM by rscott

  • Verified working set

Add Comment

Modify Ticket

Change Properties
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from jwangenheim.
Note: See TracTickets for help on using tickets.