Opened 4 months ago

Closed 3 months ago

Last modified 3 months ago

#5260 closed change (fixed)

[ABP for Samsung Internet] - Implement underline formatting to Korean

Reported by: Shikitita Assignee: jwangenheim
Priority: P3 Milestone: Adblock-Plus-for-Samsung-Browser-1.1.1
Module: Adblock-Plus-for-Samsung-Browser Keywords:
Cc: jwangenheim, diegocarloslima, mario Blocked By:
Blocking: Platform: Samsung Browser
Ready: yes Confidential: no
Tester: Unknown Verified working: yes
Review URL(s):

https://codereview.adblockplus.org/29465555/

Description (last modified by Shikitita)

Background

Different strings in the app have bold formatting in order to make that specific section stand out. Unfortunately, this isn't so noticeable for Korean.

What to change

Underline formatting should be added, in addition to the bold formatting, in order to give more emphasis to those specific sections.

Attachments (1)

KorStrings.zip (1.4 KB) - added by Shikitita 4 months ago.
Updated .xml file for Korean with the backward slashes added.

Download all attachments as: .zip

Change History (9)

Changed 4 months ago by Shikitita

Updated .xml file for Korean with the backward slashes added.

comment:1 Changed 4 months ago by diegocarloslima

  • Priority changed from Unknown to P3
  • Ready set

comment:2 Changed 3 months ago by jwangenheim

  • Owner set to jwangenheim

comment:3 Changed 3 months ago by Shikitita

  • Description modified (diff)
  • Summary changed from [ABP for Samsung Internet] - Implement backward slashes in Korean strings to [ABP for Samsung Internet] - Implement underline formatting to Korean

comment:4 Changed 3 months ago by jwangenheim

  • Milestone set to Adblock-Plus-for-Samsung-Browser-next
  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:5 Changed 3 months ago by Shikitita

As it seems it cannot be removed, attachment KorStrings.zip should therefore be ignored as it was uploaded when the issue reflected a different fix than the one decided.

Last edited 3 months ago by Shikitita (previous) (diff)

comment:6 Changed 3 months ago by abpbot

A commit referencing this issue has landed:
Issue 5260 - Implement underline formatting to Korean

comment:7 Changed 3 months ago by jwangenheim

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:8 Changed 3 months ago by Shikitita

  • Verified working set
Note: See TracTickets for help on using tickets.