Opened 2 years ago

Closed 2 years ago

Last modified 2 years ago

#5264 closed defect (fixed)

Adding a filter subscription on the options page does not work

Reported by: mjethani Assignee: mjethani
Priority: P1 Milestone: Adblock-Plus-1.13.3-for-Chrome-Opera
Module: Platform Keywords:
Cc: kzar, sebastian Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Ross Verified working: yes
Review URL(s):

https://codereview.adblockplus.org/29445648/

Description

Environment

Chrome 58
macOS Sierra 10.12
Adblock Plus 1.13.2 (changeset: 4363517a6b68)
EasyList+AA

How to reproduce

  1. Open the options page
  2. Click on "Add filter subscription", select one from the dropdown, and click Add

Observed behaviour

Nothing happens.

Expected behaviour

It should add the filter subscription.

Notes

This is a regression introduced in changeset 2cebd252b232.

Change History (5)

comment:1 Changed 2 years ago by mjethani

  • Review URL(s) modified (diff)

comment:2 Changed 2 years ago by abpbot

A commit referencing this issue has landed:
Issue 5264 - Return page objects instead of page IDs

comment:3 Changed 2 years ago by mjethani

  • Resolution set to fixed
  • Status changed from new to closed

comment:4 Changed 2 years ago by sebastian

  • Milestone set to Adblock-Plus-for-Chrome-Opera-next
  • Priority changed from Unknown to P1
  • Ready set

comment:5 Changed 2 years ago by Ross

  • Tester changed from Unknown to Ross
  • Verified working set

Fixed. Adding filter subscriptions works as expected.

ABP 1.13.2.1785
Chrome 49 / 58 / Windows 7
Chrome 58 / OS X 10.12
Opera 39 / 45 / Windows 7

Note: See TracTickets for help on using tickets.