Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#527 closed change (fixed)

[stats] Only count requests from Adblock Plus extensions

Reported by: fhd Assignee: sebastian
Priority: P1 Milestone:
Module: Infrastructure Keywords: 2014q3
Cc: trev, jobp@… Blocked By:
Blocking: Platform:
Ready: yes Confidential: no
Tester: Verified working: no
Review URL(s):

http://codereview.adblockplus.org/5438786527821824/

Description (last modified by fhd)

Background

Currently, we're counting all requests to notifications.json and exceptionrules.txt in the log processor. Since there are a few forks that also make these requests, we should only count requests from extensions that call themselves ABP.

What to change

Only count requests that have addonName set to one of those we use. Checking that it starts with adblockplus is probably sufficient, but that needs to be checked.

Change History (10)

comment:1 Changed 5 years ago by fhd

  • Cc trev added

comment:2 Changed 5 years ago by trev

This isn't something that can be fixed in the user counter - we have to ignore other extensions in the log processor for the previousDownload field.

comment:3 Changed 5 years ago by fhd

  • Description modified (diff)

comment:4 Changed 5 years ago by fhd

Changed the description a bit to avoid confusion. Feel free to elaborate in the "What to change" part.

comment:5 Changed 5 years ago by fhd

  • Priority changed from P2 to P1

Setting to P1 - since this is a change in the log processor and not the user counter as I expected, we should fix it ASAP to get proper data again.

comment:6 Changed 5 years ago by jobp

  • Cc jobp@… added

comment:7 Changed 5 years ago by sebastian

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:8 Changed 5 years ago by sebastian

  • Owner set to sebastian

comment:9 Changed 5 years ago by sebastian

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:10 Changed 5 years ago by philll

  • Keywords 2014q3 added
Note: See TracTickets for help on using tickets.