Opened 3 years ago

Closed 3 years ago

#5274 closed change (fixed)

Grant push access for Manish and Jon

Reported by: sebastian Assignee: ferris
Priority: P2 Milestone:
Module: Office-IT Keywords:
Cc: ferris, mjethani, jsonesen Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29451558/ (done)
https://codereview.adblockplus.org/29459567 (done)

Description (last modified by sebastian)

Background

As per our committer guidelines the module owner can decide to grant write access for regular contributors to the respective repositories. Hereby I, the module owner of Platform and Build-and-Release-Tools, approve write access for the developers/repositories below.

What to change

  • Grant write access for Manish Jethani to adblockpluschrome and abp2blocklist.
  • Grant write access for Jon Sonesen to adblockpluschrome and buildtools.

Attachments (1)

eyeo_rsa.pub (748 bytes) - added by mjethani 3 years ago.
Manish's SSH key

Download all attachments as: .zip

Change History (14)

comment:1 Changed 3 years ago by sebastian

@mjethani, @jsonesen: If your key isn't on the server yet, if you don't have push access to any other repositories yet, please attach your public key to this issue.

comment:2 Changed 3 years ago by sebastian

  • Description modified (diff)

comment:3 Changed 3 years ago by sebastian

  • Description modified (diff)

comment:4 Changed 3 years ago by matze

  • Priority changed from Unknown to P2
  • Ready set

comment:5 Changed 3 years ago by matze

  • Component changed from Infrastructure to Office-IT

comment:6 Changed 3 years ago by jsonesen

I have my key on the server as I currently have push access for sitescripts and cms

comment:7 Changed 3 years ago by ferris

Apologies, I didn't get any email notification from Trac when Manish attached his key. I have your key already, Jon. I'll commit the change shortly.

comment:8 Changed 3 years ago by jsonesen

No problem, thanks Ferris!

comment:9 Changed 3 years ago by ferris

  • Review URL(s) modified (diff)

Jon is in. Will add Manish in a separate commit.

comment:10 Changed 3 years ago by ferris

  • Owner set to ferris

Changed 3 years ago by mjethani

Manish's SSH key

comment:11 Changed 3 years ago by mjethani

I've updated my key to 4096-bit RSA now.

comment:12 Changed 3 years ago by ferris

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:13 Changed 3 years ago by ferris

  • Resolution set to fixed
  • Review URL(s) modified (diff)
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.