Opened 6 months ago

Last modified 3 months ago

#5276 new defect

Settings overview doesn't update filter list date

Reported by: mario Assignee: ashephard
Priority: P2 Milestone:
Module: Adblock-Plus-for-iOS Keywords:
Cc: jand, tomasnovella, sporz Blocked By:
Blocking: Platform: iOS
Ready: no Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

Description

Environment

ABP for iOS 1.1.0
iOS 10.*

How to reproduce

  1. Install ABP, enable it in the iOS settings and go through the first run slides
  2. Open ABP and go to Settings -> Configure Filter Lists
  3. Note the date of "Last filter list update" (should be the current day)
  4. Close ABP and let the phone rest for 2 days
  5. After 2 days, open ABP and go to Settings -> Configure Filter Lists

Observed behaviour

The date displayed behind "Last filter list update" is still set to the date from two days ago.

Expected behaviour

Since ABP updates filter lists in the background, the date displayed behind "Last filter list update" should be set to the date it has been updated in the background (in this very example either the day before or the current day).

Additional information

We couldn't verify if the filter list is indeed updated in the background and whether this is only a glitch in the UI. Thus please verify the update process in the background and adjust the scope of this issue if it turns out to be a problem with the updater.

Change History (5)

comment:1 Changed 6 months ago by sporz

  • Cc sporz added

comment:2 Changed 3 months ago by ashephard

  • Owner set to ashephard

comment:3 Changed 3 months ago by ashephard

Will investigate. First attempt, set background refresh to 5 minutes and tracking via breakpoint to determine whether background update is fully functional.

comment:4 Changed 3 months ago by ashephard

So, the filter list logic has an expiry date of 5 days by default. This is why the filter list wasn't updated (doesn't check for new filter list for 5 days after the last filter list was downloaded and applied).

comment:5 Changed 3 months ago by ashephard

Set the update value to be 60 seconds and simulated a background fetch request. After the operation completed, the value on the app home screen was updated to the correct 'Last Filter List Update' value.

Note: See TracTickets for help on using tickets.