Opened 2 years ago

Closed 2 years ago

Last modified 19 months ago

#5278 closed defect (fixed)

'Last download' date for each filter list installed shows 1/1/70

Reported by: tibitts Assignee: trev
Priority: P4 Milestone:
Module: Adblock-Plus-for-Firefox Keywords:
Cc: Blocked By:
Blocking: Platform: Firefox
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29459562/

Description (last modified by trev)

Environment

Linux OpenSUSE 13.2 32-bit, FF 53.0.3, ABP 2.9, filter lists - see attached screenshot

How to reproduce

  1. Open ABP Filter Preferences

Observed behaviour

The 'Last download' date for each filter list installed shows 1/1/70 - see attached screenshot.

Expected behaviour

Show the correct 'Last download' date.

What to change

Change Utils.formatTime() method to use the standard Intl.DateTimeFormatter object.

Attachments (1)

abp_filter_lists.png (69.7 KB) - added by tibitts 2 years ago.
screenshot

Download all attachments as: .zip

Change History (9)

Changed 2 years ago by tibitts

screenshot

comment:1 Changed 2 years ago by trev

  • Component changed from Unknown to Adblock-Plus-for-Firefox

This isn't an issue I can see on Ubuntu, I will try running OpenSUSE. I assume that this doesn't change after updating the filter list either? Are you using the distribution supplied Firefox package? Is it a new issue or was it always like that?

comment:2 Changed 2 years ago by trev

I can reproduce this using official Firefox 53 32-bit build on OpenSuSE 13.2 (distribution-supplied builds stopped at Firefox 50).

comment:3 Changed 2 years ago by trev

  • Description modified (diff)
  • Priority changed from Unknown to P4
  • Ready set

This appears to be a general issue with the 32-bit Firefox build - it is reproducible on both OpenSuSE and Ubuntu as long as you install the 32-bit build. It seems that nsIScriptableDateFormat implementation is broken, it will misrepresent dates despite being given correct parameters. However, seeing that nsIScriptableDateFormat is deprecated, I don't think that we can expect Mozilla to fix this. Intl.DateTimeFormat with work correctly in both 64-bit and 32-bit builds.

comment:4 Changed 2 years ago by trev

  • Owner set to trev

comment:5 Changed 2 years ago by trev

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:7 Changed 2 years ago by trev

  • Milestone set to Adblock-Plus-for-Firefox-next
  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:8 Changed 19 months ago by trev

  • Milestone Adblock-Plus-for-Firefox-next deleted

Milestone Adblock-Plus-for-Firefox-next deleted

Note: See TracTickets for help on using tickets.