Opened 2 weeks ago

Closed 2 weeks ago

Last modified 2 weeks ago

#5298 closed change (fixed)

Disable filter hit counts by default

Reported by: trev Assignee: trev
Priority: P1 Milestone: Adblock-Plus-2.9.1-for-Firefox
Module: Adblock-Plus-for-Firefox Keywords:
Cc: Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29457582/

Description (last modified by trev)

Background

https://bugzilla.mozilla.org/show_bug.cgi?id=1362779 indicates that filter hit counts might be responsible for performance issues on some websites. For reference, 250 filter hits will currently cause filters data to be updated on disk. While this is supposed to be a relatively fast operation, for some users apparently it isn't.

What to change

Disable filter hit counting by default which should be beneficial for most users. Only count filter hits for users who enable it manually (that should be filter list authors for most part).

Hints for testers

In addition to performance implications (see #5284, definitely visible on focus.de, other websites are not as clear), it should be tested that filter authors can still re-enable filter hit counting in options and it will work.

Change History (7)

comment:1 Changed 2 weeks ago by trev

  • Ready set

This has been confirmed as the source of at least some recent bug reports. The issue has been made worse by Adblock Plus 2.9 using browser.storage API to save data which is currently quite inefficient (see https://bugzilla.mozilla.org/show_bug.cgi?id=1277612 and https://bugzilla.mozilla.org/show_bug.cgi?id=1320186).

comment:2 Changed 2 weeks ago by trev

  • Owner set to trev

comment:3 Changed 2 weeks ago by trev

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:4 Changed 2 weeks ago by abpbot

A commit referencing this issue has landed:
Issue 5298 - Disable filter hit counts by default

comment:5 Changed 2 weeks ago by trev

  • Milestone set to Adblock-Plus-2.9.1-for-Firefox
  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:6 Changed 2 weeks ago by trev

  • Description modified (diff)

comment:7 Changed 2 weeks ago by rscott

LGTM. In FF 53.0.3/64bit on Ubuntu Xenial, with the out-of-the-box multiprocess setup, these are the performance profiles I get from loading focus.de and scrolling to the bottom of the page:

There's a notable user-visible performance improvement as well.

Note: See TracTickets for help on using tickets.