Opened 3 years ago

Last modified 3 years ago

#5298 closed change

Disable filter hit counts by default — at Version 3

Reported by: trev Assignee: trev
Priority: P1 Milestone: Adblock-Plus-2.9.1-for-Firefox
Module: Adblock-Plus-for-Firefox Keywords:
Cc: Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29457582/

Description

Background

https://bugzilla.mozilla.org/show_bug.cgi?id=1362779 indicates that filter hit counts might be responsible for performance issues on some websites. For reference, 250 filter hits will currently cause filters data to be updated on disk. While this is supposed to be a relatively fast operation, for some users apparently it isn't.

What to change

Disable filter hit counting by default which should be beneficial for most users. Only count filter hits for users who enable it manually (that should be filter list authors for most part).

Change History (3)

comment:1 Changed 3 years ago by trev

  • Ready set

This has been confirmed as the source of at least some recent bug reports. The issue has been made worse by Adblock Plus 2.9 using browser.storage API to save data which is currently quite inefficient (see https://bugzilla.mozilla.org/show_bug.cgi?id=1277612 and https://bugzilla.mozilla.org/show_bug.cgi?id=1320186).

comment:2 Changed 3 years ago by trev

  • Owner set to trev

comment:3 Changed 3 years ago by trev

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing
Note: See TracTickets for help on using tickets.