Opened 6 months ago

Closed 5 months ago

Last modified 5 months ago

#5300 closed change (fixed)

Distinguish OBJECT and OBJECT_SUBREQUEST requests on Firefox

Reported by: sebastian Assignee: jsonesen
Priority: P2 Milestone: Adblock-Plus-1.13.3-for-Chrome-Opera
Module: Platform Keywords: goodfirstbug
Cc: trev, jsonesen Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Ross Verified working: yes
Review URL(s):

https://codereview.adblockplus.org/29463558

Description

Background

As Chrome cannot distinguish between requests loading files handled by a plugin like Flash (i.e. object) and subsequent requests caused by such a file (i.e. object_subrequest) these types are mapped to each other. However, apparently, despite being undocumented, these requests are reported with different types to Firefox WebExtensions.

What to change

Check chrome.webRequest.ResourceType, and don't alias the OBJECT and OBJECT_SUBREQUEST types in RegExpFilter.typeMap, if object_subrequest is supported.

Change History (7)

comment:1 Changed 6 months ago by jsonesen

  • Owner set to jsonesen

comment:2 Changed 5 months ago by jsonesen

@trev:
On Friday I was looking into the ResourceType property of the browser.webRequest object. However I was unable to find the object_subrequest key value there. Although I thought I remembered seeing it previously, this was done in the debug console in firefox for the extension. Is it possible I am doing something wrong here?

comment:3 Changed 5 months ago by trev

More detailed resource types landed in Firefox 54, so the current stable isn't supporting OBJECT_SUBREQUEST yet.

comment:4 Changed 5 months ago by abpbot

A commit referencing this issue has landed:
Issue 5300 - Add feature detection for object_subrequest

comment:5 Changed 5 months ago by jsonesen

  • Resolution set to fixed
  • Review URL(s) modified (diff)
  • Status changed from new to closed

comment:6 Changed 5 months ago by sebastian

  • Milestone set to Adblock-Plus-for-Chrome-Opera-next

comment:7 Changed 5 months ago by Ross

  • Tester changed from Unknown to Ross
  • Verified working set

Implemented. This hasn't broken anything as far as I can tell so will mark verified. I need to check this properly once #5316 is implemented.

ABP 1.13.2.1785
Firefox 55 (Developer) / Windows 7
Chrome 49 / 58 / Windows 7

Note: See TracTickets for help on using tickets.