Opened 2 years ago

Closed 2 years ago

#5313 closed change (fixed)

Improve error reporting from elemHideEmulation

Reported by: hfiguiere Assignee: hfiguiere
Priority: Unknown Milestone:
Module: Core Keywords:
Cc: Blocked By: #3143
Blocking: Platform: Unknown / Cross platform
Ready: no Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29464703/

Description

Background

Following up on issue #3143. We should improve the error reporting from elemHideEmulation

Currently we have a global reportError that is a function that will call this.window.console.error(). This is not an optimal solution.

Details:
https://codereview.adblockplus.org/29383960/diff/29463575/chrome/content/elemHideEmulation.js#newcode331

What to change

  • provide an error reporter to parseSelector()

Change History (4)

comment:1 Changed 2 years ago by hfiguiere

  • Owner set to hfiguiere
  • Review URL(s) modified (diff)

comment:2 Changed 2 years ago by hfiguiere

  • Status changed from new to reviewing

comment:3 Changed 2 years ago by abpbot

A commit referencing this issue has landed:
Issue 5313 - Make error reporting more robust.

comment:4 Changed 2 years ago by hfiguiere

  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.