Opened 3 years ago

Closed 3 years ago

#5314 closed change (fixed)

Don't limit hide emulation filters to -abp pseudo class selectors

Reported by: hfiguiere Assignee: hfiguiere
Priority: Unknown Milestone:
Module: Core Keywords:
Cc: Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: no Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29464708

Description (last modified by hfiguiere)

Background

Following issue #5287, we should not limit hide emulation filters to -abp pseudo-class selector

What to change

-in lib/filterClasses.js, around line 973, remove the check.
-make sure that unless it is -abp-properties, we actually hide the elements directly.
-ensure the tests pass.

Change History (6)

comment:1 Changed 3 years ago by hfiguiere

  • Description modified (diff)

comment:2 Changed 3 years ago by hfiguiere

  • Description modified (diff)
  • Summary changed from Don't limit hiding emulation filters to -abp pseudo class selectors to Don't limit hide emulation filters to -abp pseudo class selectors

comment:3 Changed 3 years ago by hfiguiere

  • Owner set to hfiguiere

comment:4 Changed 3 years ago by hfiguiere

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:5 Changed 3 years ago by abpbot

comment:6 Changed 3 years ago by hfiguiere

  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.