Opened 2 years ago

Closed 2 years ago

#5316 closed change (fixed)

Don't hard-code resource types for the devtools panel

Reported by: sebastian Assignee: jsonesen
Priority: P3 Milestone: Adblock-Plus-3.0-for-Firefox
Module: User-Interface Keywords:
Cc: jsonesen, greiner Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29522650/
https://codereview.adblockplus.org/29522656/

Description

Background

Currently, the available resource types, you can filter for in the devtools panel are hard-coded here and here. Which resource type is supported however depends on the browser (and sometimes even the browser version). The types hard-coded there correspond to the latest Chrome version. However, on Firefox the same code will be used soon, and the set of available resource types varies there.

What to change

Dynamically generate the list of available resource types, based on the values in chrome.webRequest.ResourceType and the corresponding mapping to ABP types.

Change History (6)

comment:1 Changed 2 years ago by jsonesen

  • Owner set to jsonesen

comment:2 Changed 2 years ago by greiner

  • Cc greiner added
  • Ready set

comment:3 Changed 2 years ago by jsonesen

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:4 Changed 2 years ago by abpbot

A commit referencing this issue has landed:
Issue 5316 - Adds dynamic filter types to devtools panel

comment:5 Changed 2 years ago by abpbot

comment:6 Changed 2 years ago by sebastian

  • Milestone set to Adblock-Plus-for-Chrome-Opera-next
  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.