Opened on 06/14/2017 at 05:43:53 AM

Closed on 09/21/2017 at 04:58:37 PM

#5316 closed change (fixed)

Don't hard-code resource types for the devtools panel

Reported by: sebastian Assignee: jsonesen
Priority: P3 Milestone: Adblock-Plus-3.0-for-Firefox
Module: User-Interface Keywords:
Cc: jsonesen, greiner Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):



Currently, the available resource types, you can filter for in the devtools panel are hard-coded here and here. Which resource type is supported however depends on the browser (and sometimes even the browser version). The types hard-coded there correspond to the latest Chrome version. However, on Firefox the same code will be used soon, and the set of available resource types varies there.

What to change

Dynamically generate the list of available resource types, based on the values in chrome.webRequest.ResourceType and the corresponding mapping to ABP types.

Attachments (0)

Change History (6)

comment:1 Changed on 06/21/2017 at 11:11:16 AM by jsonesen

  • Owner set to jsonesen

comment:2 Changed on 08/03/2017 at 05:54:47 PM by greiner

  • Cc greiner added
  • Ready set

comment:3 Changed on 08/21/2017 at 03:52:22 PM by jsonesen

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:4 Changed on 09/19/2017 at 11:28:11 AM by abpbot

A commit referencing this issue has landed:
Issue 5316 - Adds dynamic filter types to devtools panel

comment:5 Changed on 09/21/2017 at 04:53:54 PM by abpbot

comment:6 Changed on 09/21/2017 at 04:58:37 PM by sebastian

  • Milestone set to Adblock-Plus-for-Chrome-Opera-next
  • Resolution set to fixed
  • Status changed from reviewing to closed

Add Comment

Modify Ticket

Change Properties
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from jsonesen.
Note: See TracTickets for help on using tickets.