Opened 2 years ago

Closed 2 months ago

#5317 closed change (duplicate)

Add support for <table> to the collection

Reported by: saroyanm Assignee:
Priority: P3 Milestone:
Module: User-Interface Keywords:
Cc: greiner Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

Description (last modified by saroyanm)

Background

We currently are using Unordered lists (UL) for the collection implementation, while it makes responsive layout implementation easier, it's semantically incorrect in some places, for example the Filter List in advanced tab is tabular data rather than list.

What to change

Add support for <table> element to the Collections component besides of the Unordered List.

Change History (8)

comment:1 Changed 2 years ago by saroyanm

I think this is good to have feature, but this shouldn't block the launch, before making this ready I would like to ask you @greiner, does it make sense to make this blocker to any of existing "new-new-options-page" tickets ?

comment:2 Changed 2 years ago by greiner

  • Priority changed from Unknown to P3
  • Ready set

I wouldn't consider this to be a blocker unless we decide to put greather emphasis on accessbility in the spec.

comment:3 Changed 2 years ago by saroyanm

  • Description modified (diff)

comment:4 follow-up: Changed 22 months ago by agiammarchi

unless we decide to put greather emphasis on accessbility in the spec.

I was wondering: are there visual specs for this?

comment:5 in reply to: ↑ 4 Changed 21 months ago by greiner

Replying to agiammarchi:

I was wondering: are there visual specs for this?

This is about an implementation change to clarify semantically that some lists represent tables. Therefore the visual looks aren't expected to be impacted by this.

comment:6 Changed 2 months ago by greiner

@saroyanm Can we close this ticket? If you still think that the approach here makes sense, feel free to create a GitLab issue for it instead.

comment:7 Changed 2 months ago by saroyanm

@greiner, there were some discussions in IRC how to tackle https://gitlab.com/eyeo/adblockplus/abpui/adblockplusui/issues/346 and this discussion has been revisited again. Thanks for pointing out this issue.

There are some things I think that needs to be improved with the element:

  • Convert to a component
  • Use <table>
  • Make table responsive
    • It might be easier to achieve responsiveness with the ul element, but should also be possible with <table> I guess.

I have created an issue to followup -> https://gitlab.com/eyeo/adblockplus/abpui/adblockplusui/issues/579

comment:8 Changed 2 months ago by saroyanm

  • Resolution set to duplicate
  • Status changed from new to closed
Note: See TracTickets for help on using tickets.