Opened 2 years ago

Closed 2 years ago

Last modified 2 years ago

#5332 closed change (fixed)

[abp2blocklist] Enable support for non-ASCII CSS selectors

Reported by: mjethani Assignee: mjethani
Priority: P3 Milestone:
Module: Platform Keywords: abp2blocklist
Cc: kzar, sebastian, mario Blocked By:
Blocking: #5464 Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29468579/
https://codereview.adblockplus.org/29468575/

Description (last modified by mjethani)

Background

A web page can contain CSS selectors containing non-ASCII characters. Currently abp2blocklist filters out any rules containing non-ASCII characters, even though Adblock Plus supports Unicode characters. This means a web page author can circumvent ABP element hiding by simply adding non-ASCII characters to their class names and element IDs.

What to change

Simply do not filter out rules containing non-ASCII characters, as Safari does support such rules.

For non-ASCII characters that appear in the path part of the URL, encode them using encodeURI.

Change History (8)

comment:1 Changed 2 years ago by mjethani

  • Description modified (diff)

comment:2 Changed 2 years ago by mjethani

  • Summary changed from [abp2blocklist] Add support for non-ASCII CSS selectors to [abp2blocklist] Enable support for non-ASCII CSS selectors

comment:3 Changed 2 years ago by mjethani

  • Review URL(s) modified (diff)

comment:4 Changed 2 years ago by mjethani

  • Description modified (diff)
  • Review URL(s) modified (diff)

comment:5 Changed 2 years ago by abpbot

comment:6 Changed 2 years ago by abpbot

A commit referencing this issue has landed:
Issue 5332 - Support Unicode characters in path

comment:7 Changed 2 years ago by kzar

  • Priority changed from Unknown to P3
  • Ready set
  • Resolution set to fixed
  • Status changed from new to closed

comment:8 Changed 2 years ago by mjethani

  • Blocking 5464 added
Note: See TracTickets for help on using tickets.