Opened on 06/19/2017 at 03:23:28 PM

Closed on 07/11/2017 at 11:29:08 AM

Last modified on 08/02/2017 at 06:30:08 AM

#5332 closed change (fixed)

[abp2blocklist] Enable support for non-ASCII CSS selectors

Reported by: mjethani Assignee: mjethani
Priority: P3 Milestone:
Module: Platform Keywords: abp2blocklist
Cc: kzar, sebastian, mario Blocked By:
Blocking: #5464 Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

Description (last modified by mjethani)


A web page can contain CSS selectors containing non-ASCII characters. Currently abp2blocklist filters out any rules containing non-ASCII characters, even though Adblock Plus supports Unicode characters. This means a web page author can circumvent ABP element hiding by simply adding non-ASCII characters to their class names and element IDs.

What to change

Simply do not filter out rules containing non-ASCII characters, as Safari does support such rules.

For non-ASCII characters that appear in the path part of the URL, encode them using encodeURI.

Attachments (0)

Change History (8)

comment:1 Changed on 06/19/2017 at 03:26:05 PM by mjethani

  • Description modified (diff)

comment:2 Changed on 06/19/2017 at 03:26:26 PM by mjethani

  • Summary changed from [abp2blocklist] Add support for non-ASCII CSS selectors to [abp2blocklist] Enable support for non-ASCII CSS selectors

comment:3 Changed on 06/19/2017 at 04:12:32 PM by mjethani

  • Review URL(s) modified (diff)

comment:4 Changed on 06/19/2017 at 04:52:48 PM by mjethani

  • Description modified (diff)
  • Review URL(s) modified (diff)

comment:5 Changed on 07/09/2017 at 01:11:30 PM by abpbot

comment:6 Changed on 07/11/2017 at 10:41:59 AM by abpbot

A commit referencing this issue has landed:
Issue 5332 - Support Unicode characters in path

comment:7 Changed on 07/11/2017 at 11:29:08 AM by kzar

  • Priority changed from Unknown to P3
  • Ready set
  • Resolution set to fixed
  • Status changed from new to closed

comment:8 Changed on 08/02/2017 at 06:30:08 AM by mjethani

  • Blocking 5464 added

Add Comment

Modify Ticket

Change Properties
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from mjethani.
Note: See TracTickets for help on using tickets.