Opened 3 years ago

Last modified 3 years ago

#5336 closed change

Allow additional include, page, and template paths using CMS — at Version 1

Reported by: juliandoucette Assignee:
Priority: P2 Milestone: Websites code sharing
Module: Sitescripts Keywords:
Cc: wspee, kvas, jsonesen, ire, saroyanm, juliandoucette Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

​https://codereview.adblockplus.org/29555839/

Description (last modified by juliandoucette)

Background

  • We would like to share code across websites
  • If I am able to add dependencies to websites (see #5335)
    • Then I could also add generic includes, pages, and templates to website-defaults
      • If CMS would allow me to load from additional paths

What to change

Allow me to specify additional global, include, page, and template paths that will resolve if they cannot be found in the default paths. e.g.

If I specify:
additional_includes=[node_modules/website-defaults/includes]

Then I:
<? include example ?>

Then:

  1. CMS should check includes/examlpe
  2. If it doesn't find example there then it should check the paths specified above
  • I'm open to suggestion about how and where this should be specified
    • The first thing that comes to mind is settings.ini

Change History (1)

comment:1 Changed 3 years ago by juliandoucette

  • Description modified (diff)

I forgot about globals :D

Real world example: If implemented, I could define a standard set of meta data fields inside includes in website-defaults and share these includes across websites (if I am able to add dependencies - #5335) instead of duplicating them in each website repository.

Note: See TracTickets for help on using tickets.