Opened 20 months ago

Last modified 18 months ago

#5341 new defect

Subscribing on https://adblockplus.org/subscriptions removes the currently selected list

Reported by: scheer Assignee:
Priority: Unknown Milestone:
Module: Adblock-Browser-for-Android Keywords:
Cc: diegocarloslima, mario, rjeschke Blocked By:
Blocking: Platform: Adblock Browser for Android
Ready: no Confidential: no
Tester: Scheer Verified working: no
Review URL(s):

Description

When the user navigates to https://adblockplus.org/subscriptions and select to subscribe to a list ABB Android will remove the currently selected list and replace it with the selected one from https://adblockplus.org/subscriptions.

There are two issues here currently.

  1. Is that if you wish to have more than one list active, by selecting them via https://adblockplus.org/subscriptions, then this is not possible.
  2. That if the user selects a non-language based filter such as EasyPrivacy, then Easylist is still removed and no list is added (as this is a tick box selection in ABB Android and not a Language selection)

We need to allow the user to select to subscribe and check if a. they have that filter list at all first and not apply it if they do and b. add it to the already selected list (allow multiple adding from https://adblockplus.org/subscriptions). In addition to this, we need to find a way to let the user know that they can choose subscriptions such as EasyPrivacy via the additional settings option (if we can't find a way to allow selecting 'Subscribe to enable this option)

Environment

adblockbrowser-1.1.1.20170612182010-arm
Galaxy S7
Android 7.0

How to reproduce

  1. Check which lists you are subscribed to
  2. Load https://adblockplus.org/subscriptions
  3. Add a language list
  4. Add EasyPrivacy

Observed behaviour

The already selected list(s) are removed and replaced by the requested list from https://adblockplus.org/subscriptions. The Easylist is removed and not replaced by anything when a non-language list is selected.

Expected behaviour

The subscription is added and no other lists are removed. The language list is not added if it is already selected in the lists menu. The language list remains and the toggle for that available list in additional options is activated.

Change History (1)

comment:1 Changed 18 months ago by diegocarloslima

This still happens in ABB 1.2.0 and in Firefox 55 with ABP 2.9.1. This is likely to require changes in the extension itself.

Note: See TracTickets for help on using tickets.