Opened 2 years ago

Closed 2 years ago

Last modified 2 years ago

#5344 closed change (worksforme)

Support element hiding emulation exception rules

Reported by: sebastian Assignee: hfiguiere
Priority: Unknown Milestone:
Module: Core Keywords:
Cc: hfiguiere, arthur, trev, greiner, mapx, fhd Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: no Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29470687/

Description (last modified by hfiguiere)

Background

With #5287 we implemented a new kind of element hiding filters which are implemented differently in order to allow some more advanced filtering. These filters, however, cannot be whitelisted yet, while regular element hiding filters like ##.ad would be whitelisted by an exception rule like #@#.ad.

What to change

If there is a filter like example.com#?@#.ad, the filter example.com#?#.ad should not have any effect.

Change History (11)

comment:1 Changed 2 years ago by greiner

  • Cc greiner added

comment:2 Changed 2 years ago by mapx

  • Cc mapx added

comment:3 Changed 2 years ago by sebastian

  • Description modified (diff)

comment:4 Changed 2 years ago by sebastian

  • Description modified (diff)

comment:5 Changed 2 years ago by hfiguiere

  • Owner set to hfiguiere

comment:6 Changed 2 years ago by hfiguiere

  • Description modified (diff)

comment:7 Changed 2 years ago by hfiguiere

  • Description modified (diff)

comment:8 Changed 2 years ago by hfiguiere

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:9 Changed 2 years ago by fhd

  • Cc fhd added

It seems that regular element hiding exceptions work for element hiding emulation rules as well. Here's what I tried in Chrome with the current devbuild:

  1. Add the following custom filter: testpages.adblockplus.org#?#.abp-testsuite-fail
  2. Go to https://testpages.adblockplus.org/en/testsuite/05
  3. Verify that the element is hidden (i.e. the box is green)
  4. Add the following custom filter: testpages.adblockplus.org#@#.abp-testsuite-fail
  5. Go to https://testpages.adblockplus.org/en/testsuite/05
  6. Verify that the element is not hidden (i.e. the box is red)

comment:10 Changed 2 years ago by trev

  • Resolution set to worksforme
  • Status changed from reviewing to closed

In fact, we are explicitly testing that element hiding exception apply to emulation rules as well. IMHO, that's sufficient as a solution, introducing a special syntax for emulation exceptions doesn't provide any additional value. So I am closing this issue, feel free to comment with your reasoning if you disagree.

comment:11 Changed 2 years ago by sebastian

For reference, this feature request was initially brought up by Arthur, and for some reason both of us just assumed that regular element hiding exception rules wouldn't work. But since they apparently do, I agree, that this issue should be closed without a fix.

Note: See TracTickets for help on using tickets.