Opened on 06/21/2017 at 05:19:22 PM

Closed on 07/05/2017 at 01:02:21 PM

Last modified on 07/05/2017 at 02:00:44 PM

#5344 closed change (worksforme)

Support element hiding emulation exception rules

Reported by: sebastian Assignee: hfiguiere
Priority: Unknown Milestone:
Module: Core Keywords:
Cc: hfiguiere, arthur, trev, greiner, mapx, fhd Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: no Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

Description (last modified by hfiguiere)


With #5287 we implemented a new kind of element hiding filters which are implemented differently in order to allow some more advanced filtering. These filters, however, cannot be whitelisted yet, while regular element hiding filters like would be whitelisted by an exception rule like

What to change

If there is a filter like, the filter should not have any effect.

Attachments (0)

Change History (11)

comment:1 Changed on 06/21/2017 at 05:22:54 PM by greiner

  • Cc greiner added

comment:2 Changed on 06/21/2017 at 05:32:12 PM by mapx

  • Cc mapx added

comment:3 Changed on 06/21/2017 at 05:34:00 PM by sebastian

  • Description modified (diff)

comment:4 Changed on 06/21/2017 at 05:34:35 PM by sebastian

  • Description modified (diff)

comment:5 Changed on 06/21/2017 at 06:02:03 PM by hfiguiere

  • Owner set to hfiguiere

comment:6 Changed on 06/21/2017 at 06:02:49 PM by hfiguiere

  • Description modified (diff)

comment:7 Changed on 06/21/2017 at 06:03:22 PM by hfiguiere

  • Description modified (diff)

comment:8 Changed on 06/21/2017 at 06:54:33 PM by hfiguiere

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:9 Changed on 07/05/2017 at 11:44:07 AM by fhd

  • Cc fhd added

It seems that regular element hiding exceptions work for element hiding emulation rules as well. Here's what I tried in Chrome with the current devbuild:

  1. Add the following custom filter:
  2. Go to
  3. Verify that the element is hidden (i.e. the box is green)
  4. Add the following custom filter:
  5. Go to
  6. Verify that the element is not hidden (i.e. the box is red)

comment:10 Changed on 07/05/2017 at 01:02:21 PM by trev

  • Resolution set to worksforme
  • Status changed from reviewing to closed

In fact, we are explicitly testing that element hiding exception apply to emulation rules as well. IMHO, that's sufficient as a solution, introducing a special syntax for emulation exceptions doesn't provide any additional value. So I am closing this issue, feel free to comment with your reasoning if you disagree.

comment:11 Changed on 07/05/2017 at 02:00:44 PM by sebastian

For reference, this feature request was initially brought up by Arthur, and for some reason both of us just assumed that regular element hiding exception rules wouldn't work. But since they apparently do, I agree, that this issue should be closed without a fix.

Add Comment

Modify Ticket

Change Properties
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from hfiguiere.
Note: See TracTickets for help on using tickets.