Changes between Initial Version and Version 1 of Ticket #5347, comment 24


Ignore:
Timestamp:
08/15/2017 02:46:20 PM (2 years ago)
Author:
mjethani
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #5347, comment 24

    initial v1  
    1010 
    1111 1.  `chrome.notifications` [https://issues.adblockplus.org/ticket/5347#comment:20 doesn't support] the `buttons` option, but we could show a button-less notification and open a new tab (using `chrome.tabs.create`) on `click` 
    12  2.  `chrome.runtime.openOptionsPage` is [https://issues.adblockplus.org/ticket/5347#comment:22 not supported on Android] , but somehow you can still call the function, it just doesn't do anything (which means we can't do feature/API detection); we'll have to resort to checking the platform here using the `info` module, and do the same thing we do on Edge (i.e. open the options page in a new tab) 
     12 2.  `chrome.runtime.openOptionsPage` is [https://issues.adblockplus.org/ticket/5347#comment:22 not supported on Android], but somehow you can still call the function, it just doesn't do anything (which means we can't do feature/API detection); we'll have to resort to checking the platform here using the `info` module, and do the same thing we do on Edge (i.e. open the options page in a new tab) 
    1313 
    1414All other APIs the extension uses are supported on Android, though there may be differences in behavior that we might run into.