Changes between Version 7 and Version 9 of Ticket #5354


Ignore:
Timestamp:
10/19/2017 01:21:04 AM (21 months ago)
Author:
sebastian
Comment:

There is already a fallback to HTML notifications, but it seems HTML notifications cannot have buttons either. So we don't use this fallback for notifications of the type question (e.g. the anti-adblock notification), and not if browser.notifications is supported anyway.

But then again, there is no point in showing the anti-adblock notification if we can not have buttons to opt-in or -out of that list. So if buttons aren't supported in browser.notifications and the notification type is question it seems best to not show the notification at all.

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #5354 – Description

    v7 v9  
    1818 
    1919=== Expected behaviour === 
    20 Notification should be displayed, but without buttons if not supported. 
     20If buttons are not supported, the notification should be displayed without buttons, except if the type of the notification is `question` in which case the notification should not be shown if buttons are not supported. Either way, no error should be logged.