Opened 2 years ago

Closed 2 years ago

Last modified 2 years ago

#5357 closed defect (invalid)

storage.js is wrongly written

Reported by: mapx Assignee:
Priority: Unknown Milestone:
Module: Adblock-Plus-for-Firefox Keywords:
Cc: trev, sebastian Blocked By:
Blocking: Platform: Firefox
Ready: no Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

Description

Environment

w10
FF 55.0b5 (32-bit)
ABP 2.9.1.4258

How to reproduce

  1. backup the filters ==> (easylist, private list, other disabled lists - easyprivacy, annoyances, social list etc)

it will result a total of 7 mega backup

  1. close FF, delete storage.js
  1. open FF, restore from backup. Initially storage.js is 7 mega, after normal navigation (2-3 pages), is already 15 mega.
  1. Next day: already 30 mega. ... Today is 45 mega.

I opened the file (in notepad++) and I found out (for example) easylist is written 6-7 times !
I searched for "&ad.vid=","&ad_box_" ==> I found 6 occorrences !

You can download my zipped storage.js here and check yourself the bug:
https://mega.nz/#!OUIXXKQD!xe-YYloMLvGXULxCLGqqPcBNCQx7WsJg3EisrgIT0H8

Change History (8)

comment:1 Changed 2 years ago by mapx

  • Sensitive set

comment:2 Changed 2 years ago by mapx

  • Cc sebastian added

comment:3 Changed 2 years ago by mapx

The same behaviour in ABP webext in Firefox (probably the storage.js is managed in the core)

comment:4 Changed 2 years ago by trev

  • Resolution set to invalid
  • Sensitive unset
  • Status changed from new to closed

This is actually the expected behavior. storage.js isn't merely replacing patterns.ini but also the automated backups. So as you are using Adblock Plus, you will get five copies of the data there. See also https://adblockplus.org/en/preferences#patternsbackups

comment:5 Changed 2 years ago by mapx

Well, 5 backups is too much, until FF will provide some other (intelligent) modality to store the data you should keep only 1 backup. Otherwise you'll see thousands complains about the lag ABP brings in FF.

comment:6 Changed 2 years ago by mapx

well, it seems pretty simple, changing the default value here:
extensions.adblockplus.patternsbackups

comment:7 Changed 2 years ago by SMed79

I don't know for what reason and without any warning my FF crashed resulting in losing my filters. The storage.js is rewrited to an empty file with a size of 2KB.
With the old automated backups I always had 5 chances to recover my data but with the new modality of data storage, ABP is swimming counter-current.

I will completely disable the backups and try to script something to backups in a separated file(s).

comment:8 Changed 2 years ago by trev

Yes, the automatic backups functionality is no longer meaningful and has been disabled in Adblock Plus 3.0 (to be released soon). Your best chance is backing up storage.js yourself, it isn't something that the extension can do any more.

Note: See TracTickets for help on using tickets.