Opened 7 months ago

Last modified 4 months ago

#5374 reviewing change

Implement Add filter list popup

Reported by: saroyanm Assignee:
Priority: P2 Milestone:
Module: User-Interface Keywords:
Cc: wspee, greiner Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29480624/

Description

Background

After several design iterations we finally have a final version of the new options page (See #5158).

What to change

Implement "add filter list popup" as specified in Options Page Specification.

Change History (7)

comment:1 Changed 7 months ago by saroyanm

  • Cc wspee greiner added
  • Owner set to saroyanm

comment:2 Changed 7 months ago by saroyanm

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:3 Changed 5 months ago by saroyanm

  • Owner saroyanm deleted
  • Priority changed from P2 to P3

As discussed: we don't need this for the initial launch as this filter lists yet possible to add from the general tab.

comment:4 follow-up: Changed 5 months ago by greiner

We do need it for the initial launch but it doesn't need to contain non-language filter lists yet.

comment:5 in reply to: ↑ 4 ; follow-up: Changed 5 months ago by saroyanm

  • Priority changed from P3 to P2

Replying to greiner:

We do need it for the initial launch but it doesn't need to contain non-language filter lists yet.

The way I remember we decided to open "Add filter list via URL" dialog meanwhile.
Anyway I'll increase priority until it's not confirmed.

comment:6 in reply to: ↑ 5 Changed 5 months ago by greiner

Replying to saroyanm:

The way I remember we decided to open "Add filter list via URL" dialog meanwhile.

Gotcha, I thought you wanted to get rid of the dialog in general but yeah, we don't need it in the Advanced tab for the initial release. Sorry about the confusion.

comment:7 Changed 4 months ago by saroyanm

  • Blocking 5158 removed

As discussed: we don't need it for the initial release.

Note: See TracTickets for help on using tickets.