Opened 14 months ago

Last modified 3 months ago

#5374 reopened change

Implement Add filter list popup

Reported by: saroyanm Assignee: agiammarchi
Priority: P2 Milestone:
Module: User-Interface Keywords:
Cc: wspee, greiner Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

Description (last modified by saroyanm)

Background

After several design iterations we finally have a final version of the new options page (See #5158).

What to change

Implement "add filter list popup" as specified in Page Specification.

Change History (20)

comment:1 Changed 14 months ago by saroyanm

  • Cc wspee greiner added
  • Owner set to saroyanm

comment:2 Changed 13 months ago by saroyanm

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:3 Changed 11 months ago by saroyanm

  • Owner saroyanm deleted
  • Priority changed from P2 to P3

As discussed: we don't need this for the initial launch as this filter lists yet possible to add from the general tab.

comment:4 follow-up: Changed 11 months ago by greiner

We do need it for the initial launch but it doesn't need to contain non-language filter lists yet.

comment:5 in reply to: ↑ 4 ; follow-up: Changed 11 months ago by saroyanm

  • Priority changed from P3 to P2

Replying to greiner:

We do need it for the initial launch but it doesn't need to contain non-language filter lists yet.

The way I remember we decided to open "Add filter list via URL" dialog meanwhile.
Anyway I'll increase priority until it's not confirmed.

comment:6 in reply to: ↑ 5 Changed 11 months ago by greiner

Replying to saroyanm:

The way I remember we decided to open "Add filter list via URL" dialog meanwhile.

Gotcha, I thought you wanted to get rid of the dialog in general but yeah, we don't need it in the Advanced tab for the initial release. Sorry about the confusion.

comment:7 Changed 11 months ago by saroyanm

  • Blocking 5158 removed

As discussed: we don't need it for the initial release.

comment:8 Changed 6 months ago by agiammarchi

  • Owner set to agiammarchi

comment:9 Changed 6 months ago by agiammarchi

  • Status changed from reviewing to reopened

comment:10 Changed 6 months ago by agiammarchi

  • Status changed from reopened to reviewing

comment:11 Changed 6 months ago by agiammarchi

  • Owner agiammarchi deleted

comment:12 Changed 6 months ago by saroyanm

  • Status changed from reviewing to reopened

comment:13 Changed 6 months ago by saroyanm

  • Review URL(s) modified (diff)

comment:14 Changed 6 months ago by agiammarchi

  • Owner set to agiammarchi

comment:15 follow-up: Changed 6 months ago by agiammarchi

This looks like a very interesting task for someone new, but I'd like to ask few questions about specifications.

Focused filter list

Is that just a hover ? Would a click or enter set that row like the last one ?
Should it move down there too ?

What actually is the last Malware Domains greyed out row ? Is it selectable too or just there disabled ?

Language filter lists

Are these shown independently of the installed filters and, if that's the case, are these shown in that table exact order ?

If that's not the case, is there any specific way to relate languages to filters beside the name ?

Add custom subscription popup

If I understand correctly the current extension popup is already the one described here as custom, beside some UI differences.

UI a part, is there anything else that needs to change in the current subscription popup ?

Close VS Cancel

Just a quess, really: is there any reason to have these two around ? The Cancel button, as described, does exactly what the closing button does.

comment:16 in reply to: ↑ 15 Changed 6 months ago by greiner

Hope you don't mind if I'll only address the ones that don't require clarification from Product.

Replying to agiammarchi:

Focused filter list

What actually is the last Malware Domains greyed out row ? Is it selectable too or just there disabled ?

It's disabled because it has already been installed.

Language filter lists

Are these shown independently of the installed filters and, if that's the case, are these shown in that table exact order ?

If that's not the case, is there any specific way to relate languages to filters beside the name ?

This dialog already exists in the General tab when you click on "+ Add a language". The only differences are that non-language filter lists need to be shown when opening it from here and that there's a button at the bottom.

Also note that the existing implementation still differs from the specced version (e.g. in regards to styling). But also that we still need to replace the dialog in the General tab with the expected UI element (see Adding / Changing a language).

Add custom subscription popup

If I understand correctly the current extension popup is already the one described here as custom, beside some UI differences.

That's correct.

comment:17 follow-up: Changed 6 months ago by agiammarchi

Hope you don't mind ...

not at all, thanks a lot for these info !

we still need to replace the dialog in the General tab with the expected UI element

wouldn't be better to have a separate ticket for that?

This once involves already quite some change but I don't see a ticket specific for the language bit in the other tab.

Glad to see I can reuse most of the current language dialog anyway

comment:18 in reply to: ↑ 17 Changed 6 months ago by greiner

Replying to agiammarchi:

wouldn't be better to have a separate ticket for that?

This once involves already quite some change but I don't see a ticket specific for the language bit in the other tab.

Absolutely. I've created #6397 for tackling that.

comment:19 Changed 6 months ago by saroyanm

  • Description modified (diff)

Replaced with the Gitlab link.

Note: Seems like the Specs in the Bitbucket and currently updated reference are different, I can't see currently Non Language Blocking Filter Lists listed.

comment:20 Changed 3 months ago by greiner

@saroyanm It looks like this has already been implemented by now or is there anything left to do here? If not please add a reference to the commit in which this change has landed and close this ticket.

Note: See TracTickets for help on using tickets.