Changes between Initial Version and Version 1 of Ticket #5375, comment 5


Ignore:
Timestamp:
09/22/2017 01:18:24 PM (2 years ago)
Author:
diegocarloslima
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #5375, comment 5

    initial v1  
    1 This is due to the fact that the search widget has a different logic for retrieving the default search engine. Instead of retrieving the search engine based on the preference `browser.search.order`, defined in `mobile.js`, which is the way it's retrieved in `SearchPreferenceCategory.java`,  it retrieves the default search engine by reading a file called `browsersearch.json`, that is located in the `res/raw/` folder.  This file is generated by the script `generate_browsersearch.py`, which takes into consideration what is defined in `browser.search.order` and `browser.search.defaultenginename` inside `region.properties`. This means that we need to adjust the search widget to use the same logic of the search preference. 
     1This is due to the fact that the search widget first reads from `res/raw-LOCALE/browsersearch.json` to determine which is the default search engine. This file is generated by calling the script `generate_browsersearch.py`, which reads the `browser.search.defaultenginename` inside each locale `region.properties`. We need to call this script once we have applied our changes in `region.properties` for each locale, so the `browsersearch.json` file will be consistent with the default search engine in the browser preferences.