Changes between Version 4 and Version 7 of Ticket #5383


Ignore:
Timestamp:
08/14/2017 03:58:10 PM (2 years ago)
Author:
sebastian
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #5383

    • Property Status changed from new to reviewing
    • Property Blocking changed from to 5484
  • Ticket #5383 – Description

    v4 v7  
    11=== Background === 
    2 Currently, the only tests we have for `buildtools` only cover the [https://hg.adblockplus.org/buildtools/file/tip/tests/test_packagerEdge.py packager for Microsoft Edge], however, not the other build targets (i.e. Chrome and Firefox). 
     2Currently, the only tests we have for `buildtools` only cover the [https://hg.adblockplus.org/buildtools/file/tip/tests/test_packagerEdge.py packager for Microsoft Edge], however, not the other relevant build targets (i.e. Chrome and Firefox). 
     3 
     4Moreover, the existing tests for the Edge packager are mostly testing the packager's internal APIs, however, not whether these are correctly integrated in the build process. 
    35 
    46=== What to change === 
    5 Add tests covering `packagerChrome.py` and `packagerGecko.py`, the same way in which tests for the Microsoft Edge builds are implemented, i.e. generating a build and compare the output with expected results. 
     7Add tests for the build process of Chrome and Gecko/WebExt extensions, and update existing tests for Edge extensions. Wherever possible functionality should be tested end-to-end as part of the build process, and not by calling internal APIs.