Opened 2 years ago

Closed 2 years ago

Last modified 2 months ago

#5383 closed change (fixed)

Add tests for the Chrome and Firefox packagers

Reported by: sebastian Assignee: tlucas
Priority: P3 Milestone:
Module: Automation Keywords: goodfirstbug
Cc: kzar, tlucas Blocked By: #4720, #5535
Blocking: #5484 Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29501558/

Description (last modified by sebastian)

Background

Currently, the only tests we have for buildtools only cover the packager for Microsoft Edge, however, not the other relevant build targets (i.e. Chrome and Firefox).

Moreover, the existing tests for the Edge packager are mostly testing the packager's internal APIs, however, not whether these are correctly integrated in the build process.

What to change

Add tests for the build process of Chrome and Gecko/WebExt extensions, and update existing tests for Edge extensions. Wherever possible functionality should be tested end-to-end as part of the build process, and not by calling internal APIs.

Change History (14)

comment:1 Changed 2 years ago by sebastian

  • Summary changed from Add tests for the Chrome and Firefox packagers. to Add tests for the Chrome and Firefox packagers

comment:2 Changed 2 years ago by tlucas

  • Cc tlucas added

comment:3 Changed 2 years ago by tlucas

  • Owner set to tlucas

comment:4 Changed 2 years ago by tlucas

  • Review URL(s) modified (diff)

comment:5 Changed 2 years ago by tlucas

  • Status changed from new to reviewing

comment:6 Changed 2 years ago by sebastian

  • Blocking 5484 added

comment:7 Changed 2 years ago by sebastian

  • Description modified (diff)

comment:8 Changed 2 years ago by tlucas

  • Status changed from reviewing to reopened

comment:9 Changed 2 years ago by tlucas

  • Status changed from reopened to reviewing

comment:10 Changed 2 years ago by tlucas

  • Blocked By 5535 added

The usage of webpack severly changes the way how the packagers behave. I expect #5535 to land soon (at least before this issue lands) - so it wouldn't make sense to have this not being blocked by #5535.

Last edited 2 years ago by tlucas (previous) (diff)

comment:11 Changed 2 years ago by tlucas

  • Blocked By 4720 added

comment:12 Changed 2 years ago by abpbot

A commit referencing this issue has landed:
Issue 5383 - Add tests for the Chrome and Firefox packagers

comment:13 Changed 2 years ago by tlucas

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:14 Changed 5 months ago by lucasashton

Version 1, edited 5 months ago by kzar (previous) (next) (diff)
Note: See TracTickets for help on using tickets.