Opened 5 months ago

Closed 5 months ago

Last modified 5 months ago

#5403 closed change (fixed)

Update adblockpluscore dependency to revision 05da8be2ec23

Reported by: trev Assignee: trev
Priority: P1 Milestone: Adblock-Plus-1.13.3-for-Chrome-Opera
Module: Platform Keywords:
Cc: sebastian, kzar, arthur Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Ross Verified working: yes
Review URL(s):

Description

Background

We need to import #5395 into Adblock Plus for Chrome.

What to change

Updating the adblockpluscore dependency should be sufficient.

Hints for testers

This change affects element hiding emulation filters only. It has to be verified that the behavior described in #5395 no longer occurs. Note that this behavior became more noticeable as the list of posts grew longer. Also, the filters in question might be removed from EasyList soon, so they should be added to the custom filters.

It should be tested that CSS property filters still work as they did in previous releases. And it should be verified that :-abp-has() filters work, even though no working filters are currently in EasyList. For example, the filter adblockplus.org#?##summary:-abp-has(#features) should hide the block above the install button on https://adblockplus.org/. Also rules combining :-abp-has() with CSS properties, for example adblockplus.org#?##summary:-abp-has(:-abp-properties(color: rgb(51, 51, 51))) should have the same effect.

Change History (8)

comment:1 Changed 5 months ago by abpbot

comment:2 Changed 5 months ago by trev

  • Resolution set to fixed
  • Status changed from new to closed

comment:3 Changed 5 months ago by trev

  • Milestone set to Adblock-Plus-1.13.3-for-Chrome-Opera

comment:4 Changed 5 months ago by arthur

  • Cc arthur added

comment:5 Changed 5 months ago by trev

The second filter proposed in "Hints for testers" isn't working, filed #5404 on that.

comment:6 Changed 5 months ago by Ross

  • Tester changed from Unknown to Ross
  • Verified working set

Done. CSS property filters still work and the problems described in #5395 no longer occur.

ABP 1.13.2.1787
Chrome 51+ / Windows 7
Opera 38+ / Windows 7

comment:7 Changed 5 months ago by kzar

Could you also do a quick test with Chrome 49 if you have a chance?

comment:8 Changed 5 months ago by Ross

It doesn't currently work in 49/50 due to #5381.

Note: See TracTickets for help on using tickets.