Opened 2 weeks ago

Last modified 2 weeks ago

#5404 reviewing defect

:-abp-properties() nested within :-abp-has() doesn't work if the relevant selector refers to outside nodes

Reported by: trev Assignee: trev
Priority: P1 Milestone:
Module: Core Keywords:
Cc: Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):



Adblock Plus for Chrome development build

How to reproduce

  1. Add rgb(51, 51, 51))) to your custom filters.
  2. Go to

Observed behaviour

The text above the download button (in particular, the feature list) is visible.

Expected behaviour

The text above the download button should be hidden.


:-abp-properties() pseudo will produce some selectors, in this particular case #summary ul. The current implementation of :-abp-has() will currently combine these selectors with the selector for the candidate element, so that we are effectively testing #summary #summary ul - this selector doesn't have any matches because the #summary element isn't located within itself.

What to change

Don't combine selectors produced by :-abp-properties(), rather limit queryElement() call to the necessary element so that no elements outside of it are returned.

Change History (4)

comment:1 Changed 2 weeks ago by trev

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:3 Changed 2 weeks ago by trev

Leaving open because this needs to land on master as well, so far this went to a branch only.

comment:4 Changed 2 weeks ago by Ross


Chrome 51+ / Windows 7
Opera 38+ / Windows 7

Note: See TracTickets for help on using tickets.