Opened 2 years ago

Closed 2 years ago

Last modified 2 months ago

#5409 closed defect (fixed)

Build fails due to mp4parse

Reported by: diegocarloslima Assignee: diegocarloslima
Priority: P2 Milestone: Adblock-Browser-for-Android-1.3.0
Module: Adblock-Browser-for-Android Keywords:
Cc: Blocked By:
Blocking: Platform: Adblock Browser for Android
Ready: yes Confidential: no
Tester: Unknown Verified working: yes
Review URL(s):

https://codereview.adblockplus.org/29487700/

Description

Build fails in abb_fennec_53_0_2_merge with the following error message:

error[E0463]: can't find crate for `cheddar`
 --> /Users/dlima/Workspace/adblockbrowser/media/libstagefright/binding/mp4parse_capi/build.rs:1:1
  |
1 | extern crate cheddar;
  | ^^^^^^^^^^^^^^^^^^^^^ can't find crate  
error: aborting due to previous error
error: Could not compile `mp4parse_capi`.

This is due to a known Firefox bug and since the fix was only pushed in Firefox 54, we need to apply this fix to our 53 merge

Change History (19)

comment:1 Changed 2 years ago by diegocarloslima

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed 2 years ago by abpbot

A commit referencing this issue has landed:
Issue 5409 - Build fails due to mp4parse

comment:3 Changed 2 years ago by diegocarloslima

  • Milestone set to Adblock-Browser-for-Android-next
  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:4 Changed 2 years ago by traynard

If this item is testable, please provide some testing information/instructions

comment:5 Changed 2 years ago by diegocarloslima

@traynard: This is a build time issue. I believe that the best way to test it is by building the ABB project and checking if it performs successfully. Since I was able to build the project in order to generate the release candidate .apk, I think that we might consider this as verified working.

Last edited 2 years ago by diegocarloslima (previous) (diff)

comment:6 Changed 2 years ago by traynard

  • Verified working set

@diegocarloslima: Thanks! Marked it as verified working then.

comment:7 Changed 13 months ago by johnson83

spam

Last edited 2 months ago by kzar (previous) (diff)

comment:8 Changed 10 months ago by zinbad

spam

Last edited 2 months ago by kzar (previous) (diff)

comment:9 Changed 7 months ago by Paradee

spam

Last edited 2 months ago by kzar (previous) (diff)

comment:10 Changed 7 months ago by vegus111

spam

Last edited 2 months ago by kzar (previous) (diff)

comment:11 Changed 7 months ago by piwpak

spam

Last edited 2 months ago by kzar (previous) (diff)

comment:12 Changed 7 months ago by uw777

spam

Last edited 2 months ago by kzar (previous) (diff)

comment:13 Changed 6 months ago by piwpak3

spam

Last edited 2 months ago by kzar (previous) (diff)

comment:14 Changed 6 months ago by homemade99

spam

Last edited 2 months ago by kzar (previous) (diff)

comment:15 Changed 5 months ago by niki555

spam

Last edited 2 months ago by kzar (previous) (diff)

comment:16 Changed 5 months ago by niki555

spam

Last edited 2 months ago by kzar (previous) (diff)

comment:17 Changed 3 months ago by nps1337

spam

Last edited 2 months ago by kzar (previous) (diff)

comment:18 Changed 3 months ago by nps1337

spam

Last edited 2 months ago by kzar (previous) (diff)

comment:19 Changed 3 months ago by impulsepp

spam

Last edited 2 months ago by kzar (previous) (diff)
Note: See TracTickets for help on using tickets.