Opened 20 months ago

Closed 19 months ago

Last modified 5 weeks ago

#5409 closed defect (fixed)

Build fails due to mp4parse

Reported by: diegocarloslima Assignee: diegocarloslima
Priority: P2 Milestone: Adblock-Browser-for-Android-1.3.0
Module: Adblock-Browser-for-Android Keywords:
Cc: Blocked By:
Blocking: Platform: Adblock Browser for Android
Ready: yes Confidential: no
Tester: Unknown Verified working: yes
Review URL(s):

https://codereview.adblockplus.org/29487700/

Description

Build fails in abb_fennec_53_0_2_merge with the following error message:

error[E0463]: can't find crate for `cheddar`
 --> /Users/dlima/Workspace/adblockbrowser/media/libstagefright/binding/mp4parse_capi/build.rs:1:1
  |
1 | extern crate cheddar;
  | ^^^^^^^^^^^^^^^^^^^^^ can't find crate  
error: aborting due to previous error
error: Could not compile `mp4parse_capi`.

This is due to a known Firefox bug and since the fix was only pushed in Firefox 54, we need to apply this fix to our 53 merge

Change History (8)

comment:1 Changed 20 months ago by diegocarloslima

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed 20 months ago by abpbot

A commit referencing this issue has landed:
Issue 5409 - Build fails due to mp4parse

comment:3 Changed 19 months ago by diegocarloslima

  • Milestone set to Adblock-Browser-for-Android-next
  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:4 Changed 18 months ago by traynard

If this item is testable, please provide some testing information/instructions

comment:5 Changed 18 months ago by diegocarloslima

@traynard: This is a build time issue. I believe that the best way to test it is by building the ABB project and checking if it performs successfully. Since I was able to build the project in order to generate the release candidate .apk, I think that we might consider this as verified working.

Last edited 18 months ago by diegocarloslima (previous) (diff)

comment:6 Changed 18 months ago by traynard

  • Verified working set

@diegocarloslima: Thanks! Marked it as verified working then.

comment:7 Changed 4 months ago by johnson83

Many casino apps are available at heng555.

Link to select good apps and download.

[url=https://www.heng555.com/]heng 555url

https://www.heng555.com/wp-content/uploads/2018/06/Header_logox3.png

comment:8 Changed 5 weeks ago by zinbad

Advertise on LINE@ for people using LINE@ Marketing to see our brand for millions to increase brand awareness, increase sales, follow effectively.

http://i0.wp.com/www.thaismescenter.com/wp-content/uploads/2019/01/n11.jpg

https://ceoonline.in.th/line-marketing/

Note: See TracTickets for help on using tickets.