Opened 2 years ago

Closed 2 years ago

Last modified 2 years ago

#5410 closed defect (fixed)

Build failed due to 'no useful preprocessor directives found'

Reported by: diegocarloslima Assignee: diegocarloslima
Priority: P2 Milestone: Adblock-Browser-for-Android-1.2.0
Module: Adblock-Browser-for-Android Keywords:
Cc: Blocked By:
Blocking: Platform: Adblock Browser for Android
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29487703/

Description (last modified by diegocarloslima)

There was a change related to preprocessing directives in Firefox 45 that causes abb_fennec_45_0_2_merge(also abb_fennec_53_0_2_merge) build to fail with the following message:

mozbuild.preprocessor.Error: ('/Users/dlima/Workspace/adblockbrowser/mobile/android/branding/adblockbrowser/locales/en-US/brand.properties', None, 'no useful preprocessor directives found', None)

In order to fix it, we need to change the jar.mn file located in the adblockbrowser/locales folder by removing the * before locale/branding/brand.properties (en-US/brand.properties)

Change History (6)

comment:1 Changed 2 years ago by diegocarloslima

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed 2 years ago by diegocarloslima

  • Description modified (diff)

comment:3 Changed 2 years ago by abpbot

comment:4 Changed 2 years ago by diegocarloslima

  • Milestone set to Adblock-Browser-for-Android-next
  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:5 Changed 2 years ago by diegocarloslima

  • Milestone changed from Adblock-Browser-for-Android-next to Adblock-Browser-for-Android-1.2.0

comment:6 Changed 2 years ago by abpbot

Note: See TracTickets for help on using tickets.