Opened 2 years ago

Closed 2 years ago

Last modified 2 years ago

#5411 closed defect (fixed)

Undefined var MOZ_ANDROID_GCM_SENDERID

Reported by: diegocarloslima Assignee: diegocarloslima
Priority: P2 Milestone: Adblock-Browser-for-Android-1.3.0
Module: Adblock-Browser-for-Android Keywords:
Cc: Blocked By:
Blocking: Platform: Adblock Browser for Android
Ready: yes Confidential: no
Tester: Unknown Verified working: yes
Review URL(s):

https://codereview.adblockplus.org/29488589/

Description

Environment

Since we don't define MOZ_ANDROID_GCM_SENDERID in our confvars.sh, the project fails to build in abb_fennec_53_0_2_merge with the following message:

mozbuild.preprocessor.Error: ('/Users/dlima/Workspace/adblockbrowser/mobile/android/app/mobile.js', 917, 'UNDEFINED_VAR', 'MOZ_ANDROID_GCM_SENDERID')

We need to either define a value for MOZ_ANDROID_GCM_SENDERID or remove it from mobile.js

Change History (6)

comment:1 Changed 2 years ago by diegocarloslima

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed 2 years ago by abpbot

A commit referencing this issue has landed:
Issue 5411 - Undefined var MOZ_ANDROID_GCM_SENDERID

comment:3 Changed 2 years ago by diegocarloslima

  • Milestone set to Adblock-Browser-for-Android-next
  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:4 Changed 2 years ago by traynard

If this item is testable, please provide some testing information/instructions

comment:5 Changed 2 years ago by diegocarloslima

@traynard: This is a build time issue. I believe that the best way to test it is by building the ABB project and checking if it performs successfully. Since I was able to build the project in order to generate the release candidate .apk, I think that we might consider this as verified working.

Last edited 2 years ago by diegocarloslima (previous) (diff)

comment:6 Changed 2 years ago by traynard

  • Verified working set

@diegocarloslima: Thanks, marking as verified working.

Note: See TracTickets for help on using tickets.