#5414 closed change (fixed)

Add style guide page to help.eyeo.com

Reported by: ire Assignee: ire
Priority: P3 Milestone: help.eyeo.com 1.0.0
Module: Websites Keywords:
Cc: juliandoucette, wspee, saroyanm, kvas Blocked By: #5336, #5413
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29567642

Description

Include basic style guide from website-defaults into the Help Center

Change History (13)

comment:1 Changed 15 months ago by ire

  • Milestone set to help.eyeo.com 1.0.0

comment:2 Changed 15 months ago by juliandoucette

  • Cc saroyanm added
  • Priority changed from Unknown to P2
  • Ready set

comment:3 Changed 15 months ago by juliandoucette

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:4 Changed 15 months ago by juliandoucette

  • Ready unset
  • Review URL(s) modified (diff)
  • Summary changed from Add style guide to help.eyeo.com to Add style guide page to help.eyeo.com

oops :p

comment:5 Changed 15 months ago by ire

  • Status changed from reviewing to reopened

comment:6 follow-up: Changed 13 months ago by ire

@juliandoucette

I'm not sure it makes sense to implement this by copy/pasting the styleguide includes from website-defaults. I think we should wait until #5336 has been implemented then add this then. What do you think?

comment:7 in reply to: ↑ 6 Changed 13 months ago by juliandoucette

  • Cc kvas added

Replying to ire:

@juliandoucette

I'm not sure it makes sense to implement this by copy/pasting the styleguide includes from website-defaults. I think we should wait until #5336 has been implemented then add this then. What do you think?

That depends if #5336 is likely to be completed soon. What do you think @kvas?

comment:8 Changed 13 months ago by juliandoucette

  • Priority changed from P2 to P3

comment:9 follow-up: Changed 13 months ago by kvas

That depends if #5336 is likely to be completed soon. What do you think @kvas?

It's not that much work really, only to start and to finish, as we say in Russia. Thanks for bugging me, I will prioritize it more.

comment:10 in reply to: ↑ 9 Changed 13 months ago by ire

  • Blocked By 5336 added

Replying to kvas:

That depends if #5336 is likely to be completed soon. What do you think @kvas?

It's not that much work really, only to start and to finish, as we say in Russia. Thanks for bugging me, I will prioritize it more.

Thanks!

comment:11 Changed 13 months ago by ire

  • Ready set
  • Review URL(s) modified (diff)
  • Status changed from reopened to reviewing

comment:12 Changed 12 months ago by abpbot

A commit referencing this issue has landed:
Issue 5414 - Add style guide page to help.eyeo.com

comment:13 Changed 12 months ago by ire

  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.