Opened 2 years ago

Closed 2 years ago

Last modified 2 years ago

#5431 closed defect (fixed)

Prevent update_copyright test from being overwritten when the script is run

Reported by: rhowell Assignee: rhowell
Priority: P3 Milestone:
Module: Sitescripts Keywords:
Cc: kvas, sebastian Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29493601

Description

Background

When the script runs to update the copyrights each year, it will also find and update the sample_file.py, thus rendering the test page useless.

What to change

codingtools/update-copyright/tests/data/sample_file.py
Adjust the formatting to generate the file programmatically, so it doesn't match the expression that the script is looking for.

Change History (4)

comment:1 Changed 2 years ago by kvas

  • Priority changed from Unknown to P3
  • Ready set

comment:2 Changed 2 years ago by abpbot

A commit referencing this issue has landed:
Issue 5431 - Fix test for copyright update script

comment:3 Changed 2 years ago by rhowell

  • Resolution set to fixed
  • Status changed from new to closed

comment:4 Changed 2 years ago by sebastian

  • Review URL(s) modified (diff)
Note: See TracTickets for help on using tickets.