Opened 2 years ago

Closed 2 years ago

Last modified 22 months ago

#5432 closed defect (fixed)

No android_package_name string resource found

Reported by: diegocarloslima Assignee: diegocarloslima
Priority: P2 Milestone: Adblock-Browser-for-Android-1.3.0
Module: Adblock-Browser-for-Android Keywords:
Cc: Blocked By:
Blocking: Platform: Adblock Browser for Android
Ready: yes Confidential: no
Tester: Unknown Verified working: yes
Review URL(s):

https://codereview.adblockplus.org/29492590/

Description (last modified by diegocarloslima)

Mozilla has changed the minSdk from 9 to 15 (More info here, here and here) and with that, they are using android:fragment instead of intent in all preferences files, that's why they removed the android_package_name string resource that was used in the android:targetPackage attribute. This is causing abb_fennec_53_0_2_mergebuild to fail with the following message:

/Users/dlima/Workspace/adblockbrowser/mobile/android/base/resources/xml/preferences_abb_abp.xml:19: error: Error: No resource found that matches the given name (at 'targetPackage' with value '@string/android_package_name').
/Users/dlima/Workspace/adblockbrowser/mobile/android/base/resources/xml/preferences_abb_abp.xml:28: error: Error: No resource found that matches the given name (at 'targetPackage' with value '@string/android_package_name').
/Users/dlima/Workspace/adblockbrowser/mobile/android/base/resources/xml/preferences_abb_abp.xml:40: error: Error: No resource found that matches the given name (at 'targetPackage' with value '@string/android_package_name').

To fix that, it seems that we can pretty much just replace our preferences from xml-v11 into the xml folder.

Change History (7)

comment:1 Changed 2 years ago by diegocarloslima

  • Description modified (diff)

comment:2 Changed 2 years ago by diegocarloslima

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:3 Changed 2 years ago by abpbot

A commit referencing this issue has landed:
Issue 5432 - No android_package_name string resource found

comment:4 Changed 2 years ago by diegocarloslima

  • Milestone set to Adblock-Browser-for-Android-next
  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:5 Changed 22 months ago by traynard

If this item is testable, please provide some testing information/instructions

comment:6 Changed 22 months ago by diegocarloslima

@traynard: This error message is related to a build issue. As I mentioned in other tickets, the fact that I was able to build the project in order to generate the release candidate .apk, might be enough to consider the build time error as verified working. Additionally, since this issue was related to the layout of the Ad blocking settings screen, you can check if it's being displayed as expected.

Last edited 22 months ago by diegocarloslima (previous) (diff)

comment:7 Changed 22 months ago by traynard

  • Verified working set

layout and functionality of Ad blocking settings screen is same as 1.2.0

Note: See TracTickets for help on using tickets.