Opened 2 years ago

Closed 2 years ago

Last modified 2 years ago

#5434 closed change (fixed)

Remote debugging settings are being shown

Reported by: diegocarloslima Assignee: diegocarloslima
Priority: P4 Milestone: Adblock-Browser-for-Android-1.2.0
Module: Adblock-Browser-for-Android Keywords:
Cc: Blocked By:
Blocking: Platform: Adblock Browser for Android
Ready: yes Confidential: no
Tester: Unknown Verified working: yes
Review URL(s):

https://codereview.adblockplus.org/29498616/

Description

Background

This is a regression of #2353 in abb_fennec_45_0_2_merge. The Developer tools settings were moved from the Settings root to Settings -> Advanced. With that, the debugging options are being shown again:

Remote debugging via USB []
Remote debugging via Wi-Fi []
Learn More >

What to change

We need to remove/hide them again.

Attachments (1)

debugging-settings.png (116.6 KB) - added by diegocarloslima 2 years ago.

Download all attachments as: .zip

Change History (6)

Changed 2 years ago by diegocarloslima

comment:1 Changed 2 years ago by diegocarloslima

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed 2 years ago by abpbot

A commit referencing this issue has landed:
Issue 5434 - Remote debugging settings are being shown

comment:3 Changed 2 years ago by diegocarloslima

  • Milestone set to Adblock-Browser-for-Android-1.2.0
  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:4 Changed 2 years ago by abpbot

A commit referencing this issue has landed:
Issue 5434 - Remote debugging settings are being shown

comment:5 Changed 2 years ago by rscott

  • Verified working set

LGTM

Note: See TracTickets for help on using tickets.