Opened 2 years ago

Closed 2 years ago

#5445 closed change (fixed)

Add missing essential meta data to acceptableads.com

Reported by: juliandoucette Assignee: juliandoucette
Priority: P2 Milestone:
Module: Websites Keywords: goodfirstbug
Cc: ire, wspee, saroyanm, lisabielik, jeen Blocked By: #5343
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29511681/

Description (last modified by juliandoucette)

Background

I will add [standard, search, social, article, etc] meta data to all websites using shared includes in website-defaults soon. However, because our websites are being actively searched and shared, I would like to add support for the following meta fields to improve our search/share results immediately.

What to change

Ensure the following fields are supported

  • title (required)
  • og:title (generated by title)
  • description (optional)
  • og:description (optional, generated by description)
  • canonical link and og:url (generated by get_canonical_link
  • og:locale and og:locale:alternate (generated by to_og_locale from #5329)

Change History (5)

comment:1 Changed 2 years ago by juliandoucette

  • Blocked By 5343 added
  • Description modified (diff)
  • Ready unset

comment:2 Changed 2 years ago by juliandoucette

  • Description modified (diff)
  • Owner set to juliandoucette
  • Ready set

comment:3 Changed 2 years ago by juliandoucette

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:4 Changed 2 years ago by abpbot

A commit referencing this issue has landed:
Issue 5445 - Add missing essential meta data to acceptableads.com

comment:5 Changed 2 years ago by juliandoucette

  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.