Opened 2 years ago

Closed 2 years ago

#5447 closed change (fixed)

Add missing essential meta data to adblockplus.org

Reported by: juliandoucette Assignee: juliandoucette
Priority: P2 Milestone:
Module: Websites Keywords: goodfirstbug
Cc: ire, wspee, saroyanm, lisabielik, jeen Blocked By: #5343
Blocking: #146, #1198, #1274 Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29511696

Description (last modified by juliandoucette)

Background

I will add [standard, search, social, article, etc] meta data to all websites using shared includes in website-defaults soon. However, because our websites are being actively searched and shared, I would like to add support for the following meta fields to improve our search/share results immediately.

What to change

Ensure the following fields are supported

  • title (required)
  • og:title (generated by title)
  • description (optional)
  • og:description (optional, generated by description)
  • canonical link and og:url (generated by get_canonical_link
  • og:locale and og:locale:alternate (generated by to_og_locale from #5329)

Change History (23)

comment:1 Changed 2 years ago by juliandoucette

  • Type changed from defect to change

comment:2 Changed 2 years ago by juliandoucette

  • Blocking 146 added

comment:3 Changed 2 years ago by juliandoucette

  • Blocking 1274 added

comment:4 Changed 2 years ago by juliandoucette

  • Description modified (diff)

comment:5 Changed 2 years ago by juliandoucette

  • Blocked By 5343 added
  • Description modified (diff)

comment:6 Changed 2 years ago by juliandoucette

  • Description modified (diff)

comment:7 Changed 2 years ago by juliandoucette

  • Description modified (diff)
  • Ready unset

comment:8 Changed 2 years ago by juliandoucette

  • Owner set to juliandoucette

comment:9 Changed 2 years ago by juliandoucette

  • Owner juliandoucette deleted

comment:10 Changed 2 years ago by juliandoucette

  • Description modified (diff)
  • Owner set to juliandoucette
  • Ready set

comment:11 Changed 2 years ago by juliandoucette

  • Description modified (diff)

comment:12 Changed 2 years ago by juliandoucette

  • Description modified (diff)

comment:13 Changed 2 years ago by juliandoucette

  • Description modified (diff)

comment:14 Changed 2 years ago by juliandoucette

  • Description modified (diff)

comment:15 Changed 2 years ago by juliandoucette

  • Blocking 1198 added

comment:16 Changed 2 years ago by juliandoucette

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:17 Changed 2 years ago by abpbot

A commit referencing this issue has landed:
Issue 5447 - Add missing essential meta data to adblockplus.org

comment:18 Changed 2 years ago by juliandoucette

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:19 Changed 2 years ago by abpbot

A commit referencing this issue has landed:
Issue 5447 - Added canonical link to standard meta include

comment:20 Changed 2 years ago by juliandoucette

  • Resolution fixed deleted
  • Status changed from closed to reopened

This change was backed-out because the page property is not reliable on blog pages.

comment:21 Changed 2 years ago by abpbot

A commit referencing this issue has landed:
Issue 5447 - Added missing essential meta data

comment:22 Changed 2 years ago by abpbot

A commit referencing this issue has landed:
Issue 5447 - Fixed 'locales' vs 'available_locales' mixup

comment:23 Changed 2 years ago by juliandoucette

  • Resolution set to fixed
  • Status changed from reopened to closed
Note: See TracTickets for help on using tickets.