Changes between Version 7 and Version 9 of Ticket #5450


Ignore:
Timestamp:
08/07/2017 03:07:37 PM (21 months ago)
Author:
sergz
Comment:

The stub had been added, JsEngine and FilterEngine are moved into Platform as well as platform specific interfaces. Now we can work in parallel on threading issues (#5118, #5179) and on modules (the issue description has been updated).

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #5450 – Description

    v7 v9  
    88there is a need in some ''paltform'' class which is responsible for `JsEngine`, `Updater`, `FilterEngine`, `Prefs`, etc. and helps to deal with asynchronity. 
    99 
    10 === What to change === 
    11 Add the stub for that class and then gradually migrate internals in order to accomplish the issues mentioned above. 
    12  
    1310=== TODO: === 
    14 - `GetJsEngine` should return a reference, not `std::shared_ptr` https://codereview.adblockplus.org/29500602/diff/29500603/include/AdblockPlus/JsEngine.h#newcode285 
     11Sort JS files out modules and add corresponding modules. In particular we need: 
     12- ''appInfo'' module, seems good to have it as a separate module, requires `JsEngine` 
     13- ''prefs'' module which loads a bare minimum required to work with preferences, requires `JsEngine` 
     14- ''filterEngine'' module which loads filterEngine, requires ''prefs'' and ''appInfo'' 
     15- ''updater'' module which requires ''prefs'', `downloader` and ''appInfo'' (I think it makes sense for present to simply make filterEngine as a dependency for it).