Opened 2 years ago

Closed 2 years ago

#5453 closed change (fixed)

Change website-defaults into a CMS compatible website

Reported by: ire Assignee: ire
Priority: P3 Milestone:
Module: Websites Keywords:
Cc: wspee, juliandoucette, saroyanm Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29509576/

Description

Background

website-defaults is currently a repository that consists of files we can include into any website. At present it includes metadata and SCSS files. Since SCSS files are compiled into CSS during development, they can be easily included from the node_modules folder. However, currently, the metadata files cannot be included directly into pages.

What to do

Change website-defaults into website compatible with our CMS. When Issue 5336 is implemented, includes within this new CMS-compatible website will be available as includes in other CMS-compatible websites.

Change History (5)

comment:1 Changed 2 years ago by ire

  • Owner set to ire
  • Priority changed from Unknown to P3
  • Ready set

comment:2 Changed 2 years ago by ire

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:3 Changed 2 years ago by ire

  • Review URL(s) modified (diff)

comment:4 Changed 2 years ago by abpbot

A commit referencing this issue has landed:
Issue 5453 - Change website-defaults into a CMS compatible website

comment:5 Changed 2 years ago by ire

  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.