Opened 3 years ago

Last modified 2 years ago

#5455 new change

Consider a way of getting rid of sleeps in tests of default implementation of timer

Reported by: sergz Assignee:
Priority: P5 Milestone:
Module: Libadblockplus Keywords:
Cc: hfiguiere Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: no Confidential: no
Tester: Unknown Verified working: no
Review URL(s):



In order to test behavior of the default implementation of timer sleeps are used. Although we don't observe failing tests here there are race conditions, it can happen that the timer thread can be "slower", what BTW can indicate a presence of some issue.

First of all we can replace some sleeps by latch and for the rest we should evaluate whether we are fine to have them or they require some changes.

Change History (3)

comment:1 Changed 3 years ago by sergz

  • Blocking 4938 added

comment:2 Changed 3 years ago by hfiguiere

  • Cc hfiguiere added

comment:3 Changed 2 years ago by sergz

  • Blocking 4938 removed
Note: See TracTickets for help on using tickets.