Opened on 07/28/2017 at 06:59:11 AM

Last modified on 03/13/2018 at 01:36:01 PM

#5455 new change

Consider a way of getting rid of sleeps in tests of default implementation of timer

Reported by: sergz Assignee:
Priority: P5 Milestone:
Module: Libadblockplus Keywords:
Cc: hfiguiere Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: no Confidential: no
Tester: Unknown Verified working: no
Review URL(s):



In order to test behavior of the default implementation of timer sleeps are used. Although we don't observe failing tests here there are race conditions, it can happen that the timer thread can be "slower", what BTW can indicate a presence of some issue.

First of all we can replace some sleeps by latch and for the rest we should evaluate whether we are fine to have them or they require some changes.

Attachments (0)

Change History (3)

comment:1 Changed on 07/28/2017 at 06:59:57 AM by sergz

  • Blocking 4938 added

comment:2 Changed on 08/02/2017 at 05:40:56 PM by hfiguiere

  • Cc hfiguiere added

comment:3 Changed on 03/13/2018 at 01:36:01 PM by sergz

  • Blocking 4938 removed

Add Comment

Modify Ticket

Change Properties
as new .
as The resolution will be set. Next status will be 'closed'.
to The owner will be changed from (none).
Next status will be 'reviewing'.
Note: See TracTickets for help on using tickets.