Opened 2 years ago

Closed 2 years ago

#5456 closed change (fixed)

Add support to specify urlFilters in the notification repository

Reported by: wspee Assignee: wspee
Priority: Unknown Milestone:
Module: Sitescripts Keywords:
Cc: kvas Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: no Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29500676/

Description

Background

In #4827/#4762 we added support for relentless notifications. They are supposed to be used for specific website but currently it's not possible to specify urlFilters attribute via the noticifation repository.

What to change

Add support to specify the urlFilters attribute of relentless notifications via the noticifation repository by specifying a space seperated list of domains:

Notification repository format:

inactive = no

severity = relentless
title.en-US = Test
message.en-US = Test
urls = foo.com bar.com

Resulting notification.json:

{
  "notifications": [
    {
      "id": "1",
      "message": {
        "en-US": "Test"
      },
      "severity": "relentless",
      "title": {
        "en-US": "Test"
      },
      "urlFilters": [
        "FOO.COM^$document",
        "BAR.COM^$document"
      ]
    }
  ],
  "version": "201707281520"
}

Change History (4)

comment:1 Changed 2 years ago by wspee

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed 2 years ago by wspee

  • Owner set to wspee

comment:4 Changed 2 years ago by wspee

  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.