Opened 2 years ago

Closed 22 months ago

Last modified 22 months ago

#5457 closed change (fixed)

Add support to specify the number of ads a user has blocked in the notification repository

Reported by: wspee Assignee: wspee
Priority: Unknown Milestone:
Module: Sitescripts Keywords:
Cc: kvas Blocked By: #5459
Blocking: Platform: Unknown / Cross platform
Ready: no Confidential: no
Tester: Ross Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29500679/

Description (last modified by wspee)

Background

For our upcoming cross promotion campaign we want to be able to show notifications to users that blocked a specific amount of ads.

What to change

Add support to specify the number of ads a user has blocked by adding a minimum and/or maximum number.

Notification repository format:

inactive = no

severity = normal
title.en-US = Test
message.en-US = Test
target = extension=adblockpluschrome blockedTotal>=10 blockedTotal<=100

Resulting notification.json:

{
  "notifications": [
    {
      "targets": [{
        "extension": "adblockpluschrome",
        "blockedTotalMin": 10,
        "blockedTotalMax": 100
      }],
      "id": "1",
      "message": {
        "en-US": "Test"
      },
      "severity": "normal",
      "title": {
        "en-US": "Test"
      }
    }
  ],
  "version": "201707281538"
}

Change History (10)

comment:1 Changed 2 years ago by wspee

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed 2 years ago by wspee

  • Owner set to wspee

comment:3 Changed 2 years ago by wspee

  • Description modified (diff)

comment:4 Changed 2 years ago by wspee

  • Blocked By 5459 added

comment:5 Changed 2 years ago by trev

  • Description modified (diff)

I've updated the suggested format as mentioned in #5459 review.

comment:6 Changed 2 years ago by wspee

  • Description modified (diff)

Made notification repository specification also use camel case to be consistent with the rest of the target notation.

comment:8 Changed 22 months ago by wspee

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:9 Changed 22 months ago by Ross

  • Tester changed from Unknown to Ross
  • Verified working set

Wrong ticket.

Last edited 22 months ago by Ross (previous) (diff)

comment:10 Changed 22 months ago by Ross

  • Verified working unset
Note: See TracTickets for help on using tickets.