Opened on 07/28/2017 at 03:41:46 PM

Closed on 09/22/2017 at 01:33:06 PM

Last modified on 09/25/2017 at 02:03:07 PM

#5457 closed change (fixed)

Add support to specify the number of ads a user has blocked in the notification repository

Reported by: wspee Assignee: wspee
Priority: Unknown Milestone:
Module: Sitescripts Keywords:
Cc: kvas Blocked By: #5459
Blocking: Platform: Unknown / Cross platform
Ready: no Confidential: no
Tester: Ross Verified working: no
Review URL(s):

Description (last modified by wspee)


For our upcoming cross promotion campaign we want to be able to show notifications to users that blocked a specific amount of ads.

What to change

Add support to specify the number of ads a user has blocked by adding a minimum and/or maximum number.

Notification repository format:

inactive = no

severity = normal
title.en-US = Test
message.en-US = Test
target = extension=adblockpluschrome blockedTotal>=10 blockedTotal<=100

Resulting notification.json:

  "notifications": [
      "targets": [{
        "extension": "adblockpluschrome",
        "blockedTotalMin": 10,
        "blockedTotalMax": 100
      "id": "1",
      "message": {
        "en-US": "Test"
      "severity": "normal",
      "title": {
        "en-US": "Test"
  "version": "201707281538"

Attachments (0)

Change History (10)

comment:1 Changed on 07/28/2017 at 03:43:27 PM by wspee

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed on 07/31/2017 at 08:34:21 AM by wspee

  • Owner set to wspee

comment:3 Changed on 07/31/2017 at 12:18:04 PM by wspee

  • Description modified (diff)

comment:4 Changed on 07/31/2017 at 03:30:27 PM by wspee

  • Blocked By 5459 added

comment:5 Changed on 08/15/2017 at 10:37:12 AM by trev

  • Description modified (diff)

I've updated the suggested format as mentioned in #5459 review.

comment:6 Changed on 08/21/2017 at 02:52:27 PM by wspee

  • Description modified (diff)

Made notification repository specification also use camel case to be consistent with the rest of the target notation.

comment:7 Changed on 09/22/2017 at 10:29:45 AM by abpbot

comment:8 Changed on 09/22/2017 at 01:33:06 PM by wspee

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:9 Changed on 09/25/2017 at 02:02:13 PM by Ross

  • Tester changed from Unknown to Ross
  • Verified working set

Wrong ticket.

Last edited on 09/25/2017 at 02:03:07 PM by Ross

comment:10 Changed on 09/25/2017 at 02:02:52 PM by Ross

  • Verified working unset

Add Comment

Modify Ticket

Change Properties
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from wspee.
Note: See TracTickets for help on using tickets.