Opened 3 months ago

Closed 2 months ago

Last modified 4 weeks ago

#5459 closed change (fixed)

Add support to show a notification based on the number of ads blocked

Reported by: wspee Assignee: wspee
Priority: P2 Milestone:
Module: Core Keywords:
Cc: trev, sebastian, greiner Blocked By:
Blocking: #5457 Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Ross Verified working: yes
Review URL(s):

https://codereview.adblockplus.org/29501607/

Description (last modified by wspee)

Background

For our upcoming cross promotion campaign we want to be able to show notifications to users that blocked a specific amount of ads.

What to change

Add support to show a notification only if the total number of ads blocked (Prefs.blocked_total) is greater than and/or less than a certain amount and only if the user didn't opt out of showing the number of ads blocked in the bubble ui (show_statsinpopup), as specified in #5457.

Change History (14)

comment:1 Changed 3 months ago by wspee

  • Description modified (diff)
  • Summary changed from Add support to show a notification based on the total ads blocked number to Add support to show a notification based on the number of ads blocked

comment:2 Changed 3 months ago by wspee

  • Description modified (diff)

comment:3 Changed 3 months ago by wspee

  • Cc snoack trev added
  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:4 Changed 3 months ago by wspee

  • Blocking 5457 added

comment:5 Changed 3 months ago by sebastian

  • Cc sebastian added; snoack removed

comment:6 follow-up: Changed 2 months ago by greiner

  • Cc greiner added

Note that we also have the preferences "show_statsinicon" and "show_statsinpopup" which I'd consider to be good indicators for users who are not interested in seeing such a notification.

So what about not showing this notification to users who have opted-out of seeing information about how many ads got blocked? (i.e. either of the two preferences is set to false) That way we could decrease the amount of negative backlash we might get from it and provide people with an easy way to avoid those kinds of notifications.

comment:7 in reply to: ↑ 6 ; follow-up: Changed 2 months ago by wspee

Replying to greiner:

Note that we also have the preferences "show_statsinicon" and "show_statsinpopup" which I'd consider to be good indicators for users who are not interested in seeing such a notification.

So what about not showing this notification to users who have opted-out of seeing information about how many ads got blocked? (i.e. either of the two preferences is set to false) That way we could decrease the amount of negative backlash we might get from it and provide people with an easy way to avoid those kinds of notifications.

Hmm although this sounds like a good idea on first glance I'm not so sure about the correlation between users disabling the number of ads block and their interest in notifications. Perhaps they disabled the number in the icon because it's ugly, or they don't like to be distracted by a changing number?

This would further complicate the blocked total notification feature, mainly in things you have to keep in mind when designing or reasoning about notifications, and I'm no not sure if it's worth it?

Also the number of ads in the bubble ui "show_statsinpopup" seems to be not configurable anyways (at least in chrome?).

comment:8 in reply to: ↑ 7 Changed 2 months ago by greiner

Replying to wspee:

Hmm although this sounds like a good idea on first glance I'm not so sure about the correlation between users disabling the number of ads block and their interest in notifications. Perhaps they disabled the number in the icon because it's ugly, or they don't like to be distracted by a changing number?
This would further complicate the blocked total notification feature, mainly in things you have to keep in mind when designing or reasoning about notifications, and I'm no not sure if it's worth it?

These are valid points. The underlying question appears to be: Do we prefer to show the notification to people who might not want to see it or to not show the notification to people who might want to see it?

Either option is fine with me as long as it's the one in favor of the user. I just wanted to bring up that this option exists since it wasn't mentioned before.

Also the number of ads in the bubble ui "show_statsinpopup" seems to be not configurable anyways (at least in chrome?).

I'm not sure whether this addresses your point but users can toggle the value for "show_statsinpopup" by clicking the "Ads blocked" menu item in the icon popup and they can toggle the value for "show_statsinicon" by clicking the "Show number in icon" checkbox in the icon popup.

comment:9 Changed 2 months ago by jeen

Good points @greiner. And at this point, I would say to not send notifications to users who have opted out of "show_statsinpopup" - as this is a clear indicator for not wanting to see any information related to ad count. I would still allow notifications for users even if they have opted out of "show_statsinicon" - as @wspee pointed out they could have disabled this option because of distraction.

comment:10 Changed 2 months ago by wspee

  • Description modified (diff)

Updated description based on the above discussion.

Last edited 2 months ago by wspee (previous) (diff)

comment:12 Changed 2 months ago by wspee

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:13 Changed 8 weeks ago by trev

  • Priority changed from Unknown to P2
  • Ready set

comment:14 Changed 4 weeks ago by Ross

  • Tester changed from Unknown to Ross
  • Verified working set

Done. This works in Chrome. Tested with variable values in notification and extension blocked total. Respects the stats_showinpopup preference. Unable to test in Opera at the moment due to #5759. Will test backend changes separately/when they land.

ABP 1.13.3.1838
Chrome 49 / 61 / Windows 7

Note: See TracTickets for help on using tickets.